Optimize local docker setup for rapid iteration#233
Conversation
…e, adding Dockerfile.dev to represent a dev setup that just mounts the monorepo dir, changing docker-compose.microservices.example.yml to docker-compose.example.yml, adding env vars to indicate whether or not build & dependency fetching should be done on startup, adding script to fetch dependencies & build on startup if configured, updating github workflows to reference the proper dockerfile, removing github workflow files that are no longer relevant
tynes
left a comment
There was a problem hiding this comment.
Any particular docs for building and running this? I think this is the kind of PR that would be good to build/run before approving.
Yeah, this should explain it -- it'll require setting up your local env to get things working end-to-end: https://optimists.atlassian.net/browse/YAS-585 |
FWIW, you don't have to go through all the setup if you just run You'll also probably want to comment out the The functionality won't be there, but this is testing that it starts without error and only conditionally rebuilds. |
…ckages and dirs to the container that are not necessary
smartcontracts
left a comment
There was a problem hiding this comment.
LGTM. Seems pretty straightforward. Glad we're removing those old dockerfiles.
ben-chain
left a comment
There was a problem hiding this comment.
Ran this locally, looks good!! One note is the readme has a small typo which says -up instead of up.
* delete and re-init * change node deps * typo
Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com>
* feat: Implement L2ProxyAdmin * refactor: move out ProxyAdmin.ProxyType into Types lib * chore: deploy L2ProxyAdmin predeploy * chore: remove unnecessary storage override * test: update tests * refactor: rename PROXY_ADMIN predeploy to L2_PROXY_ADMIN * test: add dead address test for L2ProxyAdmin
~~blocked by #205~~ ported from reth
Seems like when `reth-optimism-trie` depends on `reth-db-api` indirectly, the doctest crate couldn’t resolve `reth_db_api::…` and failing. Closes #233 Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Description
Optimizes local docker setup for rapid iteration:
Dockerfile.devto represent a dev setup that just mounts the monorepo dirOther:
Dockerfiledocker-compose.microservices.example.ymltodocker-compose.example.ymlDockerfileMetadata
Fixes
Contributing Agreement