Skip to content

Optimize local docker setup for rapid iteration#233

Merged
willmeister merged 4 commits intomasterfrom
YAS-626/DevDockerfileAndDockerCompose
Aug 27, 2020
Merged

Optimize local docker setup for rapid iteration#233
willmeister merged 4 commits intomasterfrom
YAS-626/DevDockerfileAndDockerCompose

Conversation

@willmeister
Copy link

Description

Optimizes local docker setup for rapid iteration:

  • Adds Dockerfile.dev to represent a dev setup that just mounts the monorepo dir
  • Adds env vars to indicate whether or not build & dependency fetching should be done on startup
  • Adds script to fetch dependencies & build on startup if configured

Other:

  • Removes old dockerfiles
  • Makes services run from the main Dockerfile
  • Changes docker-compose.microservices.example.yml to docker-compose.example.yml
  • Updates github workflows to reference the proper Dockerfile
  • Removes github workflow files that are no longer relevant

Metadata

Fixes

Contributing Agreement

…e, adding Dockerfile.dev to represent a dev setup that just mounts the monorepo dir, changing docker-compose.microservices.example.yml to docker-compose.example.yml, adding env vars to indicate whether or not build & dependency fetching should be done on startup, adding script to fetch dependencies & build on startup if configured, updating github workflows to reference the proper dockerfile, removing github workflow files that are no longer relevant
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular docs for building and running this? I think this is the kind of PR that would be good to build/run before approving.

@willmeister
Copy link
Author

Any particular docs for building and running this? I think this is the kind of PR that would be good to build/run before approving.

Yeah, this should explain it -- it'll require setting up your local env to get things working end-to-end: https://optimists.atlassian.net/browse/YAS-585

@willmeister
Copy link
Author

Any particular docs for building and running this? I think this is the kind of PR that would be good to build/run before approving.

FWIW, you don't have to go through all the setup if you just run docker-compose.example.yml with the following config (leaving all microservice vars unset, meaning not running any microservices):

      - RUN_L1_CHAIN_DATA_PERSISTER=
      - RUN_L2_CHAIN_DATA_PERSISTER=
      - RUN_GETH_SUBMISSION_QUEUER=
      - RUN_QUEUED_GETH_SUBMITTER=
      - RUN_CANONICAL_CHAIN_BATCH_CREATOR=
      - RUN_CANONICAL_CHAIN_BATCH_SUBMITTER=
      - RUN_STATE_COMMITMENT_CHAIN_BATCH_CREATOR=
      - RUN_STATE_COMMITMENT_CHAIN_BATCH_SUBMITTER=
      - RUN_FRAUD_DETECTOR=

You'll also probably want to comment out the geth_l2 and postgres docker services.

The functionality won't be there, but this is testing that it starts without error and only conditionally rebuilds.

Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems pretty straightforward. Glad we're removing those old dockerfiles.

Copy link
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this locally, looks good!! One note is the readme has a small typo which says -up instead of up.

@willmeister willmeister merged commit e3a42e1 into master Aug 27, 2020
@willmeister willmeister deleted the YAS-626/DevDockerfileAndDockerCompose branch August 27, 2020 23:02
snario pushed a commit that referenced this pull request Apr 14, 2021
* delete and re-init

* change node deps

* typo
xibao-nr pushed a commit to node-real/combo-optimism that referenced this pull request Feb 19, 2025
Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com>
shenkeyao referenced this pull request in EspressoSystems/optimism-espresso-integration Mar 1, 2025
QuentinI referenced this pull request in EspressoSystems/optimism-espresso-integration Mar 7, 2025
agusduha pushed a commit that referenced this pull request Mar 20, 2025
* feat: Implement L2ProxyAdmin

* refactor: move out ProxyAdmin.ProxyType into Types lib

* chore: deploy L2ProxyAdmin predeploy

* chore: remove unnecessary storage override

* test: update tests

* refactor: rename PROXY_ADMIN predeploy to L2_PROXY_ADMIN

* test: add dead address test for L2ProxyAdmin
theochap pushed a commit that referenced this pull request Dec 10, 2025
Adds codecov to CI
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
~~blocked by #205~~

ported from reth
emhane added a commit that referenced this pull request Feb 3, 2026
Seems like when `reth-optimism-trie` depends on `reth-db-api`
indirectly, the doctest crate couldn’t resolve `reth_db_api::…` and
failing.

Closes #233

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants