fix(sdk): correctly handle no batch case#2214
Conversation
🦋 Changeset detectedLatest commit: f37c283 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2214 +/- ##
===========================================
- Coverage 73.35% 73.33% -0.02%
===========================================
Files 84 84
Lines 2766 2768 +2
Branches 472 473 +1
===========================================
+ Hits 2029 2030 +1
- Misses 737 738 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Great, that fixes the problem for me. Would it be possible to add logging of the transaction hash of the L1 transaction that is sent? |
Hmmm where would you want the logging added? I'd prefer not to add logging directly into the SDK, although I could add logging into the message relayer if that's what you're asking. |
In the message relayer is completely fine. It would just be good to know which transactions are send by the relayer. |
|
@palango Ok great, I will make a PR for that. Thank you for the feedback! Also, feel free to email me at [kelvin AT optimism DOT io] for a hand-drawn contributor NFT since you've been making a lot of great issues :-) |
|
@palango is this PR sufficient? https://github.com/ethereum-optimism/optimism/pull/2217/files |
Yes, perfect. Thanks a lot! |
Fixes the SDK so that it correctly handles the case where no batches have been submitted to the StateCommitmentChain yet. Only happens in development or immediately after a new chain is started.
5329ab4 to
f37c283
Compare
…p-rs/kona#2289) Closes #2214 Closes #2215 Closes #2255 Closes #2256
Description
Fixes the SDK so that it correctly handles the case where no batches
have been submitted to the StateCommitmentChain yet. Only happens in
development or immediately after a new chain is started.
Metadata