Skip to content

deps: bump hardhat #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smartcontracts merged 3 commits into from
Mar 25, 2022
Merged

deps: bump hardhat #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
847a633
ops: bump hardhat version in docker hardhat-node
tynes Mar 4, 2022
d9a5115
packages: bump to hardhat@2.9.2
tynes Mar 4, 2022
7dc5bff
fix(ct): bug in GasPriceOracle test
smartcontracts Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/twelve-shrimps-add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@eth-optimism/contracts': patch
'@eth-optimism/data-transport-layer': patch
'@eth-optimism/integration-tests': patch
'@eth-optimism/message-relayer': patch
'@eth-optimism/sdk': patch
Copy link
Contributor

@maurelian maurelian Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@eth-optimism/sdk': patch
'@eth-optimism/sdk': patch
'@eth-optimism/hardhat-node': patch

Copy link
Contributor

@maurelian maurelian Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then can delete the other changeset file.

Copy link
Contributor Author

@tynes tynes Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I particularly had 2 changeset files because the auto generated changelogs create a link to the commit that the changeset was added in, so to use changesets correctly, you should have the changeset in the same commit as the changes it corresponds to

---

Bump to hardhat@2.9.1
5 changes: 5 additions & 0 deletions .changeset/weak-walls-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/hardhat-node': patch
---

Bump to hardhat@2.9.1
2 changes: 1 addition & 1 deletion integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"eslint-plugin-unicorn": "^32.0.1",
"ethereum-waffle": "^3.3.0",
"ethers": "^5.5.4",
"hardhat": "^2.3.0",
"hardhat": "^2.9.2",
"hardhat-gas-reporter": "^1.0.4",
"lint-staged": "11.0.0",
"mocha": "^8.4.0",
Expand Down
7 changes: 4 additions & 3 deletions ops/docker/hardhat/hardhat.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
const isForkModeEnabled = !!process.env.FORK_URL
const forkUrl = process.env.FORK_URL
const forkStartingBlock = parseInt(process.env.FORK_STARTING_BLOCK) || undefined
const gasPrice = parseInt(process.env.GAS_PRICE) || 0
const forkStartingBlock =
parseInt(process.env.FORK_STARTING_BLOCK, 10) || undefined
const gasPrice = parseInt(process.env.GAS_PRICE, 10) || 0

const config = {
networks: {
hardhat: {
gasPrice,
initialBaseFeePerGas: 0
initialBaseFeePerGas: 0,
},
},
analytics: { enabled: false },
Expand Down
2 changes: 1 addition & 1 deletion ops/docker/hardhat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
},
"license": "MIT",
"dependencies": {
"hardhat": "^2.7.0"
"hardhat": "^2.9.2"
}
}
2 changes: 1 addition & 1 deletion packages/contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"ethereum-waffle": "^3.3.0",
"ethers": "^5.5.4",
"glob": "^7.1.6",
"hardhat": "^2.3.0",
"hardhat": "^2.9.2",
"hardhat-deploy": "^0.9.3",
"hardhat-gas-reporter": "^1.0.4",
"hardhat-output-validator": "^0.1.18",
Expand Down
6 changes: 3 additions & 3 deletions packages/contracts/test/contracts/L2/predeploys/OVM_GasPriceOracle.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ describe('OVM_GasPriceOracle', () => {
await signer1.getAddress()
)

OVM_GasPriceOracle.setOverhead(2750)
OVM_GasPriceOracle.setScalar(1500000)
OVM_GasPriceOracle.setDecimals(6)
await OVM_GasPriceOracle.setOverhead(2750)
await OVM_GasPriceOracle.setScalar(1500000)
await OVM_GasPriceOracle.setDecimals(6)
Copy link
Contributor

@maurelian maurelian Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how was this test suite working without this?

Copy link
Contributor

@maurelian maurelian Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it just become a race condition that always worked out for us?

Copy link
Contributor Author

@tynes tynes Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup exactly

})

describe('owner', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/data-transport-layer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"eslint-plugin-prettier": "^3.4.0",
"eslint-plugin-react": "^7.24.0",
"eslint-plugin-unicorn": "^32.0.1",
"hardhat": "^2.3.0",
"hardhat": "^2.9.2",
"lint-staged": "11.0.0",
"mocha": "^8.4.0",
"pino-pretty": "^4.7.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/message-relayer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"eslint-plugin-react": "^7.24.0",
"eslint-plugin-unicorn": "^32.0.1",
"ethereum-waffle": "^3.3.0",
"hardhat": "^2.3.0",
"hardhat": "^2.9.2",
"lint-staged": "11.0.0",
"prettier": "^2.3.1",
"ts-node": "^10.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"eslint-plugin-unicorn": "^32.0.1",
"ethereum-waffle": "^3.4.0",
"ethers": "^5.5.4",
"hardhat": "^2.3.0",
"hardhat": "^2.9.2",
"lint-staged": "11.0.0",
"mocha": "^8.4.0",
"nyc": "^15.1.0",
Expand Down
Loading