This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Conversation
theochap
added
K-fix
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
refcell
approved these changes
Jun 13, 2025
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Description This PR fixes some of the outstanding todos in kona's codebase. In particular: - Promotes the dial period to CLI argument for p2p. Also does a small refactor to the way the connection gater is configured - Open an issue to phase out the `sync-req-resp` optimism protocol op-rs/kona#2141. Removed the todo to promote the configuration to CLI since the node would not sync properly if the flag is not set, and this protocol will eventually get phased out. Progress towards op-rs/kona#2119
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Description This PR fixes some of the outstanding todos in kona's codebase. In particular: - Promotes the dial period to CLI argument for p2p. Also does a small refactor to the way the connection gater is configured - Open an issue to phase out the `sync-req-resp` optimism protocol #2141. Removed the todo to promote the configuration to CLI since the node would not sync properly if the flag is not set, and this protocol will eventually get phased out. Progress towards #2119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some of the outstanding todos in kona's codebase. In particular:
sync-req-respoptimism protocol fix(node/p2p): remove support for sync-req-resp optimism protocol once it gets deprecated in theop-node#2141. Removed the todo to promote the configuration to CLI since the node would not sync properly if the flag is not set, and this protocol will eventually get phased out.Progress towards #2119