l2geth: fix startup logic for repairing queue index#2114
Conversation
🦋 Changeset detectedLatest commit: bc342ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
force-pushed
the
fix/l2geth-startup-logic
branch
from
866ce53 to
9043e45
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2114 +/- ##
===========================================
- Coverage 73.37% 72.63% -0.75%
===========================================
Files 85 85
Lines 2836 2872 +36
Branches 464 469 +5
===========================================
+ Hits 2081 2086 +5
- Misses 755 786 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tynes
force-pushed
the
fix/l2geth-startup-logic
branch
from
9043e45 to
2355859
Compare
mslipper
force-pushed
the
fix/l2geth-startup-logic
branch
from
2355859 to
bc342ec
Compare
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM, what are the implications here?
|
The implications here are that the original logic for fixing the queue was broken, it would always hit the else clause since they would never match in the initial if clause. This exists to prevent deposits from being skipped/double ingested on restarts when the deposit is partway through the ingestion pipeline |
## Overview Standardizes the envvar prefix for all kona-node CLI options. Also adds the `KONA_` prefix for the global metrics args.
## Overview Missed one in #2114; Adds an envvar for the rollup config. Co-authored-by: refcell <abigger87@gmail.com>
## Overview Missed one in #2114; Adds an envvar for the rollup config. Co-authored-by: refcell <abigger87@gmail.com>
5 participants
Description
Fix a comparison on startup