Skip to content

Depreciated unused variable from Integration tests #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smartcontracts merged 1 commit into from
Feb 1, 2022
Merged

Depreciated unused variable from Integration tests #2112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions integration-tests/test/native-eth.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
DEFAULT_TEST_GAS_L1,
DEFAULT_TEST_GAS_L2,
envConfig,
PROXY_SEQUENCER_ENTRYPOINT_ADDRESS,
withdrawalTest,
} from './shared/utils'
import { OptimismEnv } from './shared/env'
Expand All @@ -31,9 +30,6 @@ describe('Native ETH Integration Tests', async () => {
const l1BobBalance = await l1Bob.getBalance()
const l2BobBalance = await l2Bob.getBalance()

const sequencerBalance = await _env.ovmEth.balanceOf(
Copy link
Contributor

@smartcontracts smartcontracts Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to remove the reference to sequencerBalance shown below (on line 47)

Copy link
Contributor Author

@RishiKumarRay RishiKumarRay Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smartcontracts i have removed it, please review and thanks for letting me know this

PROXY_SEQUENCER_ENTRYPOINT_ADDRESS
)
const l1BridgeBalance = await _env.l1Wallet.provider.getBalance(
_env.l1Bridge.address
)
Expand All @@ -44,7 +40,6 @@ describe('Native ETH Integration Tests', async () => {
l1BobBalance,
l2BobBalance,
l1BridgeBalance,
sequencerBalance,
}
}

Expand Down
2 changes: 0 additions & 2 deletions integration-tests/test/shared/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ export const gasPriceOracleWallet = new Wallet(
)

// Predeploys
export const PROXY_SEQUENCER_ENTRYPOINT_ADDRESS =
'0x4200000000000000000000000000000000000004'
export const OVM_ETH_ADDRESS = predeploys.OVM_ETH

export const L2_CHAINID = procEnv.L2_CHAINID
Expand Down