feat: regenerate receipt json for optimism fields#2032
Merged
Conversation
🦋 Changeset detectedLatest commit: d4bf299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Can you add a changeset and squash into a single commit? |
annieke
force-pushed
the
annie/regen-receipt-ovm-fields
branch
from
8e67fbf to
ba17476
Compare
annieke
force-pushed
the
annie/regen-receipt-ovm-fields
branch
from
ba17476 to
d4bf299
Compare
Contributor
Author
|
@tynes oops, done and rebased! |
Codecov Report
@@ Coverage Diff @@
## develop #2032 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 79 79
Lines 2554 2554
Branches 401 401
========================================
Hits 1905 1905
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tynes
approved these changes
Jan 19, 2022
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
## Description This PR adds a shim protocol for the sync-req-resp protocol supported by the op-node here https://specs.optimism.io/protocol/rollup-node-p2p.html#payload_by_number. This handler will always return the `Not Found` response. This will ensure that `op-nodes` are not penalizing the `kona-nodes` for not supporting it. We can remove this handler once the `op-node` team phases out support for the `sync-req-resp` protocol. ## Side notes This PR removes the environment variables in the kurtosis network configuration to disable the `req-resp` protocol. Network appears to remain stable and kona-nodes are not penalized Closes #2032 and hopefully #1929 --------- Co-authored-by: clabby <ben@clab.by>
theochap
added a commit
that referenced
this pull request
Jan 14, 2026
…kona#2042) ## Description This PR adds a shim protocol for the sync-req-resp protocol supported by the op-node here https://specs.optimism.io/protocol/rollup-node-p2p.html#payload_by_number. This handler will always return the `Not Found` response. This will ensure that `op-nodes` are not penalizing the `kona-nodes` for not supporting it. We can remove this handler once the `op-node` team phases out support for the `sync-req-resp` protocol. ## Side notes This PR removes the environment variables in the kurtosis network configuration to disable the `req-resp` protocol. Network appears to remain stable and kona-nodes are not penalized Closes #2032 and hopefully #1929 --------- Co-authored-by: clabby <ben@clab.by>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for fully unmarshaling a receipt response into the Receipt type, which currently errors on hex values in OVM fields.
Additional context
Metadata