Skip to content

chore(deps): bump @openzeppelin/contracts-upgradeable from 4.4.0 to 4.4.1#1929

Closed
dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.4.1
Closed

chore(deps): bump @openzeppelin/contracts-upgradeable from 4.4.0 to 4.4.1#1929
dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.4.1

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2021

Bumps @openzeppelin/contracts-upgradeable from 4.4.0 to 4.4.1.

Release notes

Sourced from @​openzeppelin/contracts-upgradeable's releases.

v4.4.1

⚠️ This is a patch for a low severity vulnerability. For more information visit the security advisory.

  • Initializable: change the existing initializer modifier and add a new onlyInitializing modifier to prevent reentrancy risk. (#3006)

Breaking change

It is no longer possible to call an initializer-protected function from within another initializer function outside the context of a constructor. Projects using OpenZeppelin upgradeable proxies should continue to work as is, since in the common case the initializer is invoked in the constructor directly. If this is not the case for you, the suggested change is to use the new onlyInitializing modifier in the following way:

 contract A {
-    function initialize() public   initializer { ... }
+    function initialize() internal onlyInitializing { ... }
 }
 contract B is A {
     function initialize() public initializer {
         A.initialize();
     }
 }
Changelog

Sourced from @​openzeppelin/contracts-upgradeable's changelog.

4.4.1 (2021-12-10)

  • Initializable: change the existing initializer modifier and add a new onlyInitializing modifier to prevent reentrancy risk. (#3006)

Breaking change

It is no longer possible to call an initializer-protected function from within another initializer function outside the context of a constructor. Projects using OpenZeppelin upgradeable proxies should continue to work as is, since in the common case the initializer is invoked in the constructor directly. If this is not the case for you, the suggested change is to use the new onlyInitializing modifier in the following way:

 contract A {
-    function initialize() public   initializer { ... }
+    function initialize() internal onlyInitializing { ... }
 }
 contract B is A {
     function initialize() public initializer {
         A.initialize();
     }
 }
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added M-dependencies Meta: updates dependencies javascript labels Dec 14, 2021
@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2021

⚠️ No Changeset found

Latest commit: 0b6faa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #1929 (0b6faa2) into develop (a7cf8e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1929   +/-   ##
========================================
  Coverage    74.42%   74.42%           
========================================
  Files           79       79           
  Lines         2545     2545           
  Branches       397      397           
========================================
  Hits          1894     1894           
  Misses         651      651           
Flag Coverage Δ
batch-submitter 62.50% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 87.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cf8e6...0b6faa2. Read the comment docs.

Bumps [@openzeppelin/contracts-upgradeable](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable) from 4.4.0 to 4.4.1.
- [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/releases)
- [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/master/CHANGELOG.md)
- [Commits](OpenZeppelin/openzeppelin-contracts-upgradeable@v4.4.0...v4.4.1)

---
updated-dependencies:
- dependency-name: "@openzeppelin/contracts-upgradeable"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.4.1 branch from a766aa9 to 0b6faa2 Compare December 29, 2021 17:12
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 13, 2022

Superseded by #2004.

@dependabot dependabot bot closed this Jan 13, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/openzeppelin/contracts-upgradeable-4.4.1 branch January 13, 2022 16:10
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

This PR adds a shim protocol for the sync-req-resp protocol supported by
the op-node here
https://specs.optimism.io/protocol/rollup-node-p2p.html#payload_by_number.

This handler will always return the `Not Found` response. This will
ensure that `op-nodes` are not penalizing the `kona-nodes` for not
supporting it.

We can remove this handler once the `op-node` team phases out support
for the `sync-req-resp` protocol.

## Side notes

This PR removes the environment variables in the kurtosis network
configuration to disable the `req-resp` protocol. Network appears to
remain stable and kona-nodes are not penalized

Closes #2032 and hopefully #1929

---------

Co-authored-by: clabby <ben@clab.by>
theochap added a commit that referenced this pull request Jan 14, 2026
…kona#2042)

## Description

This PR adds a shim protocol for the sync-req-resp protocol supported by
the op-node here
https://specs.optimism.io/protocol/rollup-node-p2p.html#payload_by_number.

This handler will always return the `Not Found` response. This will
ensure that `op-nodes` are not penalizing the `kona-nodes` for not
supporting it.

We can remove this handler once the `op-node` team phases out support
for the `sync-req-resp` protocol.

## Side notes

This PR removes the environment variables in the kurtosis network
configuration to disable the `req-resp` protocol. Network appears to
remain stable and kona-nodes are not penalized

Closes #2032 and hopefully #1929

---------

Co-authored-by: clabby <ben@clab.by>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-dependencies Meta: updates dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant