added internal and external imports separation within integration tests

[lucadonnoh]

Description
Separated internal and external imports in integration tests

Additional context
Some comments where missing, others were wrong (Internal and External switched)

Metadata

• Fixes Separate internal and external imports within integration tests #2017

[changeset-bot]

⚠️ No Changeset found

Latest commit: e634bf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov-commenter]

Codecov Report

Merging #2019 (df7846f) into develop (e634bf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2019   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files           79       79           
  Lines         2554     2554           
  Branches       401      401           
========================================
  Hits          1905     1905           
  Misses         649      649           

Flag	Coverage Δ
batch-submitter	62.50% <ø> (ø)
contracts	90.48% <ø> (ø)
core-utils	57.50% <ø> (ø)
data-transport-layer	38.64% <ø> (ø)
message-relayer	70.86% <ø> (ø)
sdk	88.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e634bf2...df7846f. Read the comment docs.

[smartcontracts]

Unfortunately I'm having issues seeing the integration test error on my current wifi. Going to take another look at this later tonight.

[indeavr]

I would also recommend that we enforce this order in eslint (top level - .eslintrc.js):

current:

'import/order': 'off'

New:

'import/order': [
      1,
      {
        groups: [
          'external',
          'builtin',
          'internal',
          'sibling',
          'parent',
          'index',
        ],
        'newlines-between': 'always',
      },
    ],

The groups property defines the order :)

[smartcontracts]

I would also recommend that we enforce this order in eslint (top level - .eslintrc.js):

current:

'import/order': 'off'

New:

'import/order': [
      1,
      {
        groups: [
          'external',
          'builtin',
          'internal',
          'sibling',
          'parent',
          'index',
        ],
        'newlines-between': 'always',
      },
    ],

The groups property defines the order :)

Whoa! I didn't know this was a thing we could do. I'll make an issue for this :-)

[smartcontracts]

@lucadonnoh looks like this just needs a quick rebase to fix the merge conflicts. Great work as usual!

[lucadonnoh]

sorry for the mess, i'm just learning how to contribute to a repo! 😅

[smartcontracts]

Haha, no worries @lucadonnoh. Just let me know if you need any help!

[tynes]

This unfortunately now has merge conflicts and needs to be fixed

[mslipper]

This is already complete - closing for now.