Conversation
Update the regenesis surgery tests to use the `GenesisJsonProvider`. Remove hardhat to test with and use `ts-mocha` instead.
|
|
For some reason, not all of the tests run when running |
| accs = env.getAccountsByType(AccountType.UNISWAP_V3_OTHER) | ||
| }) | ||
|
|
||
| // TODO: for some reason these tests fail |
There was a problem hiding this comment.
Perhaps due to a config issue
There was a problem hiding this comment.
I think this needs to account for the update to the WETH address
Codecov Report
@@ Coverage Diff @@
## regenesis/0.5.0 #1689 +/- ##
===================================================
+ Coverage 72.72% 81.00% +8.27%
===================================================
Files 69 47 -22
Lines 2273 1437 -836
Branches 336 214 -122
===================================================
- Hits 1653 1164 -489
+ Misses 620 273 -347
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
is the current integration test failu re a flaky test? seems unrelated https://github.com/ethereum-optimism/optimism/runs/4100597218?check_suite_focus=true#step:11:172 |
| console.log('Initializing pre GenesisJsonProvider...') | ||
| // Convert the genesis dump into a genesis file format | ||
| const genesis = { ...this.surgeryDataSources.genesis } | ||
| for (const account of this.surgeryDataSources.genesisDump) { |
There was a problem hiding this comment.
should this be iterating over this.surgeryDataSources.dump instead, since the state dump is the one with the accounts?
| throw new Error('Must initialize with genesis or state object') | ||
| } | ||
|
|
||
| this._isProvider = false |
There was a problem hiding this comment.
super nit, isLiveProvider instead?
There was a problem hiding this comment.
This is part of the Provider interface
| }) | ||
|
|
||
| it('should have the same code as on mainnet', async () => { | ||
| if (!env.hasLiveProviders()) { |
There was a problem hiding this comment.
I think this test should be runnable w/o a live provider as long as you have a connection to ETH?
|
|
||
| describe('V3 NFPM', () => { | ||
| it('should have the same code as on mainnet', async () => { | ||
| if (!env.hasLiveProviders()) { |
There was a problem hiding this comment.
Same comment as above w/r/t being runnable
|
|
||
| describe('V3 pools', () => { | ||
| before(async () => { | ||
| it('Pools', () => { |
There was a problem hiding this comment.
Some of these tests should be runnable
| accs = env.getAccountsByType(AccountType.UNISWAP_V3_OTHER) | ||
| }) | ||
|
|
||
| // TODO: for some reason these tests fail |
There was a problem hiding this comment.
I think this needs to account for the update to the WETH address
4 participants
Description
Update the regenesis surgery tests to use the
GenesisJsonProvider.Remove hardhat to test with and use
ts-mochainstead.