fix(op-service): harden RetryProxy to stabilize TestImplementations#19593
Merged
fix(op-service): harden RetryProxy to stabilize TestImplementations#19593
Conversation
…laky test The TestImplementations test (66 flakes) relies on the devnet RetryProxy to forward RPC calls to external mainnet/sepolia endpoints. Under CI load (12 parallel nodes on a 2xlarge), the proxy's tight timeouts caused intermittent failures: - Per-request timeout of 5s was insufficient for slow external RPCs under load; increased to 30s (matching the Anvil startup timeout bump in #19424) - Max retries of 5 was too few for sustained rate limiting; increased to 10 - Start() had a race condition: used a 100ms timer instead of a proper ready signal, and failed to return after net.Listen errors. Replaced with a channel-based ready signal that blocks until the listener is actually bound. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
geoknee
approved these changes
Mar 17, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19583
RetryProxyhad overly tight timeouts (5s per-request, 5 max retries) for CI conditions with 12 parallel nodes hitting external RPCs. Also had a race condition inStart()using a timer instead of a ready signal.Test plan
go build ./op-service/...passes🤖 Generated with Claude Code