fix(op-deployer): remove t.Parallel() from TestSuperchain to prevent CI flakes#19682
Closed
fix(op-deployer): remove t.Parallel() from TestSuperchain to prevent CI flakes#19682
Conversation
Remove t.Parallel() from testSuperchain to prevent mainnet and sepolia subtests from running concurrently. Each subtest starts a RetryProxy + Anvil instance forking from an external RPC; running them in parallel causes resource contention and timeouts under CI load. Same fix as #18019 for TestImplementations. Closes #19586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.Parallel()fromtestSuperchainto eliminate resource contention between parallel Anvil+RetryProxy instances under CI loadTestImplementationsin op-deployer: harden TestImplementations and cli_runner #18019Root Cause
testSuperchaincalledt.Parallel(), causingmainnetandsepoliasubtests to run concurrently. Each subtest creates a RetryProxy + Anvil instance forking from an external RPC. Under CI load, the combined resource pressure (CPU, network, RPC rate limits) causes timeouts and connection failures.The RetryProxy hardening in #19593 (longer timeouts, more retries) helped but was insufficient —
TestSuperchaincontinued to flake (45 times per the tracking issue).Why Flaky (Not Always Failing)
CI node load varies per run. Under light load, both subtests complete within their 5-minute timeout. Under heavy load, resource contention causes one or both to fail.
Test Plan
testImplementationsalready hast.Parallel()removed (op-deployer: harden TestImplementations and cli_runner #18019)devnet.NewForked()patternCloses #19586
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com