fix(op-deployer): stabilize TestSuperchain flaky test#19582
Closed
fix(op-deployer): stabilize TestSuperchain flaky test#19582
Conversation
Remove t.Parallel() from testSuperchain to prevent concurrent Anvil instances and external RPC calls from competing for resources under CI load. This mirrors the same fix applied to TestImplementations in 3a372df which resolved the identical flake pattern in that test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Claude: Closing this PR — the RetryProxy hardening in #19593 (longer timeouts, more retries, startup race fix) should stabilize TestSuperchain as well, since both tests use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19586
testSuperchaincalledt.Parallel(), causing mainnet and sepolia subtests to run concurrently. Each starts a RetryProxy + Anvil forking from an external RPC. Under CI load, this resource contention causes timeouts.t.Parallel()— same fix applied to TestImplementations in op-deployer: harden TestImplementations and cli_runner #18019.Test plan
go build ./op-deployer/...passes🤖 Generated with Claude Code