chore: migrate rust/op-reth Makefiles to just#19525
Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
ajsutton
force-pushed
the
aj/chore/migrate-op-reth-makefiles-to-just
branch
from
a3f6d9e to
9f66d34
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19525 +/- ##
==========================================
- Coverage 75.6% 75.5% -0.1%
==========================================
Files 675 675
Lines 71571 71571
==========================================
- Hits 54111 54069 -42
- Misses 17316 17358 +42
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9 tasks
ajsutton
added a commit
that referenced
this pull request
Mar 15, 2026
The large-kona-sequencer devnet config spins up 9 nodes (1 kona sequencer with reth + 4 kona validators with reth + 4 kona validators with geth). On xlarge (8 vCPU, 16GB RAM) the container is consistently killed by the OOM killer before any test step runs, producing failures with no visible failed steps. Split large-kona-sequencer out of the matrix and give it 2xlarge (16 vCPU, 32GB RAM) to accommodate the memory requirements of the full devnet. Fixes flaky failures on #19548 (job 4581496) and #19525 (job 4581006). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Port all targets from the three Makefiles under rust/op-reth/ to justfiles, following the same deprecation pattern used by Go packages. - rust/op-reth/justfile: expanded with all targets from the Makefile (build, install, cross-compilation, docker, lint, test, profiling) - rust/op-reth/tests/justfile: new file with Go e2e test targets - rust/op-reth/crates/tests/justfile: new file with Go e2e + docker targets - All three Makefiles replaced with deprecation shims that forward to just - CI updated to use `just test-e2e-sysgo` instead of `make test-e2e-sysgo` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address review feedback: use env() for FEATURES so that docker-build-push-tags can override it in sub-invocations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… targets - Wrap `cd BIN_DIR` in subshells so cwd doesn't persist across subsequent just/cp commands in the bash shebang block - Remove build-native and build-cross from deprecated targets — these are parameterized just recipes that require a target argument and didn't exist as standalone Make targets (the original had pattern rules build-native-% and build-%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The generic deprecated-target macro can't handle Make pattern rules. Add manual shims that forward make build-native-<target> to just build-native <target> and make build-<target> to just build-cross <target>, matching the original Makefile behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajsutton
force-pushed
the
aj/chore/migrate-op-reth-makefiles-to-just
branch
from
3219b3f to
678f7a5
Compare
3 tasks
wwared
approved these changes
Mar 16, 2026
wwared
reviewed
Mar 16, 2026
4 tasks
Update all three READMEs under rust/op-reth/ to reference `just` recipes instead of `make` targets. Also fix the tests/README.md which described a stale Kurtosis-based workflow that no longer matched the actual Makefile targets — replaced with the current sysgo-based workflow matching the justfile. Remove the stale `make ef-tests` reference from the main README (no such target existed in the Makefile or justfile). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wrap bare `go test` invocations with `gotestsum --junitfile` in the kona tests justfile and op-reth tests Makefile so that all rust-e2e CI jobs produce JUnit XML. Add `store_test_results` and `store_artifacts` steps to all 4 jobs in rust-e2e.yml so CircleCI Test Insights can surface per-test timing, flake detection, and failure details. The kona-proof-action-tests job already produced JUnit XML via gotestsum but never uploaded it — this change adds the missing CI upload steps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
theochap
approved these changes
Mar 17, 2026
Member
theochap
left a comment
theochap
left a comment
There was a problem hiding this comment.
Looks good provided CI pass, thanks for taking care of it
…st-results chore(ci): capture JUnit XML test results for rust-e2e jobs
5 tasks
3 tasks
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
Mar 19, 2026
* chore: migrate rust/op-reth Makefiles to just Port all targets from the three Makefiles under rust/op-reth/ to justfiles, following the same deprecation pattern used by Go packages. - rust/op-reth/justfile: expanded with all targets from the Makefile (build, install, cross-compilation, docker, lint, test, profiling) - rust/op-reth/tests/justfile: new file with Go e2e test targets - rust/op-reth/crates/tests/justfile: new file with Go e2e + docker targets - All three Makefiles replaced with deprecation shims that forward to just - CI updated to use `just test-e2e-sysgo` instead of `make test-e2e-sysgo` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: make FEATURES overridable via env in op-reth justfile Address review feedback: use env() for FEATURES so that docker-build-push-tags can override it in sub-invocations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: subshell cd in build-release-tarballs, remove invalid deprecated targets - Wrap `cd BIN_DIR` in subshells so cwd doesn't persist across subsequent just/cp commands in the bash shebang block - Remove build-native and build-cross from deprecated targets — these are parameterized just recipes that require a target argument and didn't exist as standalone Make targets (the original had pattern rules build-native-% and build-%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add manual shims for build-% and build-native-% pattern rules The generic deprecated-target macro can't handle Make pattern rules. Add manual shims that forward make build-native-<target> to just build-native <target> and make build-<target> to just build-cross <target>, matching the original Makefile behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix default target. * docs: update op-reth READMEs to reflect make-to-just migration Update all three READMEs under rust/op-reth/ to reference `just` recipes instead of `make` targets. Also fix the tests/README.md which described a stale Kurtosis-based workflow that no longer matched the actual Makefile targets — replaced with the current sysgo-based workflow matching the justfile. Remove the stale `make ef-tests` reference from the main README (no such target existed in the Makefile or justfile). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore(ci): capture JUnit XML test results for rust-e2e jobs Wrap bare `go test` invocations with `gotestsum --junitfile` in the kona tests justfile and op-reth tests Makefile so that all rust-e2e CI jobs produce JUnit XML. Add `store_test_results` and `store_artifacts` steps to all 4 jobs in rust-e2e.yml so CircleCI Test Insights can surface per-test timing, flake detection, and failure details. The kona-proof-action-tests job already produced JUnit XML via gotestsum but never uploaded it — this change adds the missing CI upload steps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
Mar 23, 2026
* chore: migrate rust/op-reth Makefiles to just Port all targets from the three Makefiles under rust/op-reth/ to justfiles, following the same deprecation pattern used by Go packages. - rust/op-reth/justfile: expanded with all targets from the Makefile (build, install, cross-compilation, docker, lint, test, profiling) - rust/op-reth/tests/justfile: new file with Go e2e test targets - rust/op-reth/crates/tests/justfile: new file with Go e2e + docker targets - All three Makefiles replaced with deprecation shims that forward to just - CI updated to use `just test-e2e-sysgo` instead of `make test-e2e-sysgo` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: make FEATURES overridable via env in op-reth justfile Address review feedback: use env() for FEATURES so that docker-build-push-tags can override it in sub-invocations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: subshell cd in build-release-tarballs, remove invalid deprecated targets - Wrap `cd BIN_DIR` in subshells so cwd doesn't persist across subsequent just/cp commands in the bash shebang block - Remove build-native and build-cross from deprecated targets — these are parameterized just recipes that require a target argument and didn't exist as standalone Make targets (the original had pattern rules build-native-% and build-%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add manual shims for build-% and build-native-% pattern rules The generic deprecated-target macro can't handle Make pattern rules. Add manual shims that forward make build-native-<target> to just build-native <target> and make build-<target> to just build-cross <target>, matching the original Makefile behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix default target. * docs: update op-reth READMEs to reflect make-to-just migration Update all three READMEs under rust/op-reth/ to reference `just` recipes instead of `make` targets. Also fix the tests/README.md which described a stale Kurtosis-based workflow that no longer matched the actual Makefile targets — replaced with the current sysgo-based workflow matching the justfile. Remove the stale `make ef-tests` reference from the main README (no such target existed in the Makefile or justfile). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore(ci): capture JUnit XML test results for rust-e2e jobs Wrap bare `go test` invocations with `gotestsum --junitfile` in the kona tests justfile and op-reth tests Makefile so that all rust-e2e CI jobs produce JUnit XML. Add `store_test_results` and `store_artifacts` steps to all 4 jobs in rust-e2e.yml so CircleCI Test Insights can surface per-test timing, flake detection, and failure details. The kona-proof-action-tests job already produced JUnit XML via gotestsum but never uploaded it — this change adds the missing CI upload steps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust/op-reth/to justfiles, following the same deprecation shim pattern used by Go packagesrust/op-reth/justfile: expanded with all targets from the Makefile — build, install, cross-compilation (via parameterizedbuild-cross/build-nativerecipes), docker build+push, lint (fmt, clippy, typos, toml), test, profiling, and release tarball creationrust/op-reth/tests/justfile: new file with Go e2e test targets (build,build-contracts,build-bedrock-contracts,test-e2e-sysgo)rust/op-reth/crates/tests/justfile: new file with Go e2e + docker build targets (build,build-docker,build-docker-with-cov,build-contracts,unzip-contract-artifacts,update-packages,test-e2e-sysgo)justfiles/deprecated.mkto print warnings and forward tojust.circleci/continue/rust-e2e.ymlto usejust test-e2e-sysgoinstead ofmake test-e2e-sysgoTest plan
just --listworks in each of the three directoriesmake buildinrust/op-reth/and confirm deprecation warning appears and forwards tojust buildjust test-e2e-sysgocommandjust lint,just build,just test-unit🤖 Generated with Claude Code