Skip to content

chore: replace stale make calls with just#19596

Merged
stevennevins merged 2 commits intodevelopfrom
aj/chore/stale-make-refs
Mar 17, 2026
Merged

chore: replace stale make calls with just#19596
stevennevins merged 2 commits intodevelopfrom
aj/chore/stale-make-refs

Conversation

@ajsutton
Copy link
Copy Markdown
Contributor

Summary

Audit and cleanup of remaining make references after the Make → Just migration (#19546).

  • build-prestates.sh and build-legacy-cannons.sh: Use just when a justfile is present at the checked-out tag, fall back to make for older tags that predate the migration
  • op-alt-da/Dockerfile and op-dispute-mon/Dockerfile: Update stale comments referencing make golang-dockerjust golang-docker

Note: rust/op-reth/tests/ was already handled by #19525.

Test plan

  • Verify build-prestates.sh still works for both old tags (no justfile → make) and new tags (justfile → just)
  • Verify build-legacy-cannons.sh builds cannon embeds correctly across tag versions
  • Confirm no other stale make references remain (audit checked CI configs, Dockerfiles, scripts, and docs)

🤖 Generated with Claude Code

build-prestates.sh and build-legacy-cannons.sh build from historic tags
where justfiles may not exist yet, so prefer just when a justfile is
present and fall back to make otherwise. Also updates stale "make
golang-docker" comments in Dockerfiles.

Part of #19546.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ajsutton ajsutton marked this pull request as ready for review March 17, 2026 10:07
@ajsutton ajsutton requested a review from a team as a code owner March 17, 2026 10:07
Tags like kona-client/v1.2.10-rc.1 have a justfile but predate the
reproducible-prestate recipe. Check that the recipe exists with
`just --show <recipe>` before attempting to use it, falling back to
make when the recipe is missing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.4%. Comparing base (ba64213) to head (e485c54).
⚠️ Report is 7 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (ba64213) and HEAD (e485c54). Click for more details.

HEAD has 19 uploads less than BASE
Flag BASE (ba64213) HEAD (e485c54)
contracts-bedrock-tests 16 0
unit 2 0
cannon-go-tests-64 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19596      +/-   ##
===========================================
- Coverage     75.5%    66.4%    -9.2%     
===========================================
  Files          675       55     -620     
  Lines        71562     4030   -67532     
===========================================
- Hits         54071     2677   -51394     
+ Misses       17347     1209   -16138     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (ø)
contracts-bedrock-tests ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 620 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ajsutton ajsutton added this pull request to the merge queue Mar 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 17, 2026
@stevennevins stevennevins added this pull request to the merge queue Mar 17, 2026
Merged via the queue into develop with commit 643d4f1 Mar 17, 2026
101 checks passed
@stevennevins stevennevins deleted the aj/chore/stale-make-refs branch March 17, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants