chore: replace stale make calls with just#19596
Merged
stevennevins merged 2 commits intodevelopfrom Mar 17, 2026
Merged
Conversation
build-prestates.sh and build-legacy-cannons.sh build from historic tags where justfiles may not exist yet, so prefer just when a justfile is present and fall back to make otherwise. Also updates stale "make golang-docker" comments in Dockerfiles. Part of #19546. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tags like kona-client/v1.2.10-rc.1 have a justfile but predate the reproducible-prestate recipe. Check that the recipe exists with `just --show <recipe>` before attempting to use it, falling back to make when the recipe is missing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wwared
approved these changes
Mar 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #19596 +/- ##
===========================================
- Coverage 75.5% 66.4% -9.2%
===========================================
Files 675 55 -620
Lines 71562 4030 -67532
===========================================
- Hits 54071 2677 -51394
+ Misses 17347 1209 -16138
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit and cleanup of remaining
makereferences after the Make → Just migration (#19546).build-prestates.shandbuild-legacy-cannons.sh: Usejustwhen a justfile is present at the checked-out tag, fall back tomakefor older tags that predate the migrationop-alt-da/Dockerfileandop-dispute-mon/Dockerfile: Update stale comments referencingmake golang-docker→just golang-dockerNote:
rust/op-reth/tests/was already handled by #19525.Test plan
build-prestates.shstill works for both old tags (no justfile → make) and new tags (justfile → just)build-legacy-cannons.shbuilds cannon embeds correctly across tag versionsmakereferences remain (audit checked CI configs, Dockerfiles, scripts, and docs)🤖 Generated with Claude Code