fix(op-devstack): add 5m timeout to txs in GameHelper#19556
Merged
fix(op-devstack): add 5m timeout to txs in GameHelper#19556
Conversation
TestChallengerRespondsToMultipleInvalidClaimsEOA hung for 2 hours in CI (the full Go binary timeout) with no deterministic code-level bug. The EOA variant uses EIP-7702 to delegate code to a GameHelper contract, then calls PerformMoves which relies on gas estimation. If eth_estimateGas hangs for a 7702-delegated EOA target, the call blocks for the entire parent context lifetime (~2 hours in CI). Add a 30-second timeout context around the EstimateGas call in WithEstimator so a hanging RPC call fails fast instead of consuming the entire test budget. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TestChallengerRespondsToMultipleInvalidClaimsEOA hung for 2 hours in CI (the full Go binary timeout). All Eval calls in GameHelper inherited the test's ~2-hour context with no per-transaction timeout, so a hanging RPC call (e.g. eth_estimateGas for an EIP-7702 delegated EOA) blocked silently for the entire duration. Add a 5-minute timeout context around each Eval call in GameHelper (deploy, AuthEOA, CreateGameWithClaims, PerformMoves). This bounds the entire tx lifecycle — estimation, signing, submission, and inclusion — so any single hanging operation fails fast. Also reverts the txplan.WithEstimator timeout from the previous commit, since the timeout belongs at the caller level, not in infrastructure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wwared
changed the title
wwared
approved these changes
Mar 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.WithTimeoutaround eachEvalcall inGameHelper(deploy, AuthEOA, CreateGameWithClaims, PerformMoves)Motivation
TestChallengerRespondsToMultipleInvalidClaimsEOAhung for 2 hours in CI (the full Go binary timeout) on PR #19525. Investigation showed:SetCodeTxType) to delegate an EOA to a GameHelper contractEvalcalls inGameHelperpassgs.t.Ctx()which inherits the test's ~2-hour context deadlineeth_estimateGasfor a 7702-delegated EOA), it blocks silently for the entire durationClaimID,shouldCounter,honestClaimTracker) — the hang occurs in the tx lifecycle, not in game resolutionThe 5-minute timeout bounds the entire tx lifecycle (estimation, signing, submission, inclusion) so any single hanging operation fails fast instead of consuming the full test budget.
Test plan
go build ./op-devstack/dsl/proofs/...compilesTestChallengerRespondsToMultipleInvalidClaimsEOA— should either pass or fail fast (not hang for 2 hours)🤖 Generated with Claude Code