Skip to content

fix: no gas price for static fns in deploy#1758

Merged
tynes merged 1 commit intodevelopfrom
sc/fix-deploy-calls
Nov 18, 2021
Merged

fix: no gas price for static fns in deploy#1758
tynes merged 1 commit intodevelopfrom
sc/fix-deploy-calls

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Nov 12, 2021

Description
Fixes the issue that we experienced yesterday where static calls would fail because we provide a gas price. Now, if the function is constant (static), we provide an explicit gas price of 0.

I also renamed hardhat-deploy-ethers.ts (a terrible file name) to deploy-utils.ts.

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2021

🦋 Changeset detected

Latest commit: b904940

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/batch-submitter Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #1758 (b904940) into develop (12b153a) will increase coverage by 8.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1758      +/-   ##
===========================================
+ Coverage    71.81%   80.33%   +8.51%     
===========================================
  Files           69       47      -22     
  Lines         2303     1449     -854     
  Branches       344      218     -126     
===========================================
- Hits          1654     1164     -490     
+ Misses         649      285     -364     
Flag Coverage Δ
batch-submitter ?
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer ?
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h-submitter/src/batch-submitter/batch-submitter.ts
packages/data-transport-layer/src/utils/eth-tx.ts
packages/data-transport-layer/src/utils/index.ts
packages/batch-submitter/hardhat.config.ts
...ices/l1-ingestion/handlers/state-batch-appended.ts
...ackages/batch-submitter/src/utils/tx-submission.ts
...ckages/data-transport-layer/src/utils/constants.ts
.../l1-ingestion/handlers/sequencer-batch-appended.ts
.../batch-submitter/src/transaction-chain-contract.ts
packages/batch-submitter/src/utils/index.ts
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b153a...b904940. Read the comment docs.

@tynes tynes merged commit 244d4e3 into develop Nov 18, 2021
@tynes tynes deleted the sc/fix-deploy-calls branch November 18, 2021 15:42
@maurelian
Copy link
Contributor

Integration tests are failing after merging this to develop. I just hit re-run 👌

The error is:

  95 passing (12m)
  1 pending
  1 failing

  1) stress tests
       C-C-C-Combo breakers
         3 L2 transactions, L1 => L2 transactions, L2 => L1 transactions (all parallel):
     Error: timeout (requestBody="{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0xf88606808301a6fb944b6ab5f819a515382b0deb6935d793817bb4af2880a49faa1de3424242424242424242424242424242424242424242424242424242424242424282036ba08307d6e9c690b490a74e6406df4a3f8a31286c53879d3d00fa290e8fdb23a465a04baf07cb20690ec9c2b9f4ca2e9184e9da78b21a3811e7e9219f89750b2a64eb\"],\"id\":3722,\"jsonrpc\":\"2.0\"}", requestMethod="POST", timeout=120000, url="http://l2geth:8545", code=TIMEOUT, version=web/5.4.0)
      at Logger.makeError (/optimism/node_modules/@ethersproject/logger/src.ts/index.ts:213:28)
      at Timeout._onTimeout (/optimism/node_modules/@ethersproject/web/src.ts/index.ts:180:35)
      at listOnTimeout (internal/timers.js:557:17)
      at processTimers (internal/timers.js:500:7)

theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants