fix: no gas price for static fns in deploy#1758
Merged
Conversation
🦋 Changeset detectedLatest commit: b904940 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5261b46 to
b904940
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1758 +/- ##
===========================================
+ Coverage 71.81% 80.33% +8.51%
===========================================
Files 69 47 -22
Lines 2303 1449 -854
Branches 344 218 -126
===========================================
- Hits 1654 1164 -490
+ Misses 649 285 -364
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tynes
approved these changes
Nov 12, 2021
maurelian
approved these changes
Nov 18, 2021
Contributor
|
Integration tests are failing after merging this to The error is: |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue that we experienced yesterday where static calls would fail because we provide a gas price. Now, if the function is constant (static), we provide an explicit gas price of 0.
I also renamed
hardhat-deploy-ethers.ts(a terrible file name) todeploy-utils.ts.