fix: no gas price for static fns in deploy

.changeset/lovely-pumas-sing.md

@@ -0,0 +1,5 @@
+---
+'@eth-optimism/contracts': patch
+---
+
+Use a gas price of zero for static calls in the deploy process

packages/contracts/deploy/000-hardhat-setup.ts

@@ -6,7 +6,7 @@ import {
   fundAccount,
   sendImpersonatedTx,
   BIG_BALANCE,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 import { awaitCondition } from '@eth-optimism/core-utils'
 

packages/contracts/deploy/002-OVM_ChainStorageContainer_ctc_batches.deploy.ts

@@ -5,7 +5,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/003-OVM_ChainStorageContainer_scc_batches.deploy.ts

@@ -5,7 +5,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/004-OVM_CanonicalTransactionChain.deploy.ts

@@ -5,7 +5,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/005-OVM_StateCommitmentChain.deploy.ts

@@ -5,7 +5,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/006-OVM_BondManager.deploy.ts

@@ -5,7 +5,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/007-OVM_L1CrossDomainMessenger.deploy.ts

@@ -6,7 +6,7 @@ import { hexStringEquals, awaitCondition } from '@eth-optimism/core-utils'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/008-Proxy__OVM_L1CrossDomainMessenger.deploy.ts

@@ -5,7 +5,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/009-Proxy__OVM_L1StandardBridge.deploy.ts

@@ -2,7 +2,7 @@
 import { DeployFunction } from 'hardhat-deploy/dist/types'
 
 /* Imports: Internal */
-import { deployAndVerifyAndThen } from '../src/hardhat-deploy-ethers'
+import { deployAndVerifyAndThen } from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/010-AddressDictator.deploy.ts

@@ -6,7 +6,7 @@ import { hexStringEquals } from '@eth-optimism/core-utils'
 import {
   deployAndVerifyAndThen,
   getContractFromArtifact,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 import { predeploys } from '../src/predeploys'
 

packages/contracts/deploy/011-set-addresses.ts

@@ -3,10 +3,7 @@ import { hexStringEquals, awaitCondition } from '@eth-optimism/core-utils'
 import { DeployFunction } from 'hardhat-deploy/dist/types'
 
 /* Imports: Internal */
-import {
-  getContractFromArtifact,
-  isHardhatNode,
-} from '../src/hardhat-deploy-ethers'
+import { getContractFromArtifact, isHardhatNode } from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/012-initialize-Proxy__L1CrossDomainMessenger.ts

@@ -3,7 +3,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import { hexStringEquals, awaitCondition } from '@eth-optimism/core-utils'
 
 /* Imports: Internal */
-import { getContractFromArtifact } from '../src/hardhat-deploy-ethers'
+import { getContractFromArtifact } from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/013-ChugSplashDictator.deploy.ts

@@ -8,7 +8,7 @@ import { getContractDefinition } from '../src/contract-defs'
 import {
   getContractFromArtifact,
   deployAndVerifyAndThen,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/014-OVM_L1StandardBridge.deploy.ts

@@ -9,7 +9,7 @@ import {
   getContractFromArtifact,
   deployAndVerifyAndThen,
   isHardhatNode,
-} from '../src/hardhat-deploy-ethers'
+} from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 const deployFn: DeployFunction = async (hre) => {

packages/contracts/deploy/015-finalize.ts

@@ -3,7 +3,7 @@ import { DeployFunction } from 'hardhat-deploy/dist/types'
 import { hexStringEquals, awaitCondition } from '@eth-optimism/core-utils'
 
 /* Imports: Internal */
-import { getContractFromArtifact } from '../src/hardhat-deploy-ethers'
+import { getContractFromArtifact } from '../src/deploy-utils'
 
 const deployFn: DeployFunction = async (hre) => {
   const { deployer } = await hre.getNamedAccounts()

packages/contracts/deploy/016-fund-accounts.ts

@@ -5,10 +5,7 @@ import { defaultHardhatNetworkHdAccountsConfigParams } from 'hardhat/internal/co
 import { normalizeHardhatNetworkAccountsConfig } from 'hardhat/internal/core/providers/util'
 
 /* Imports: Internal */
-import {
-  getContractFromArtifact,
-  isHardhatNode,
-} from '../src/hardhat-deploy-ethers'
+import { getContractFromArtifact, isHardhatNode } from '../src/deploy-utils'
 import { names } from '../src/address-names'
 
 // This is a TEMPORARY way to fund the default hardhat accounts on L2. The better way to do this is

packages/contracts/src/hardhat-deploy-ethers.ts → packages/contracts/src/deploy-utils.ts

@@ -103,8 +103,16 @@ export const getAdvancedContract = (opts: {
   for (const fnName of Object.keys(contract.functions)) {
     const fn = contract[fnName].bind(contract)
     ;(contract as any)[fnName] = async (...args: any) => {
+      // We want to use the gas price that has been configured at the beginning of the deployment.
+      // However, if the function being triggered is a "constant" (static) function, then we don't
+      // want to provide a gas price because we're prone to getting insufficient balance errors.
+      let gasPrice = opts.hre.deployConfig.gasPrice || undefined
+      if (contract.interface.getFunction(fnName).constant) {
+        gasPrice = 0
+      }
+
       const tx = await fn(...args, {
-        gasPrice: opts.hre.deployConfig.gasprice || undefined,
+        gasPrice,
       })
 
       if (typeof tx !== 'object' || typeof tx.wait !== 'function') {