Fold EngDeriver into EngController

[teddyknox]

Description

EngDeriver is only superficially separate from EngController, in that all of its event handling logic delegates to calls in EngController. In order to disintermediate events that EngDeriver handles, it would be nice to be able to have event emitters store a reference only to EngController, but call into the handlers in EngDeriver. Thus, we merge the two so that this is possible.

Separately, we MUST refactor EngController to be less monolithic.

Tests

EngDeriver is not well tested right now. This is something we will fix when refactoring EngController.

Additional context

Metadata

[codecov]

Codecov Report

❌ Patch coverage is 73.66255% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.58%. Comparing base (7bb754f) to head (95a21ab).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines	Patch %	Lines
op-node/rollup/engine/engine_controller.go	72.82%	48 Missing and 5 partials ⚠️
op-node/rollup/driver/driver.go	0.00%	3 Missing ⚠️
op-node/rollup/attributes/attributes.go	81.81%	1 Missing and 1 partial ⚠️
op-node/rollup/engine/payload_success.go	60.00%	1 Missing and 1 partial ⚠️
op-program/client/driver/driver.go	0.00%	2 Missing ⚠️
op-node/rollup/engine/payload_invalid.go	0.00%	1 Missing ⚠️
op-node/rollup/engine/payload_process.go	66.66%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7bb754f) and HEAD (95a21ab). Click for more details.

HEAD has 4 uploads less than BASE

Flag	BASE (7bb754f)	HEAD (95a21ab)
cannon-go-tests-64	3	0
contracts-bedrock-tests	2	1

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #17015       +/-   ##
============================================
- Coverage    81.89%   44.58%   -37.31%     
============================================
  Files          161     1405     +1244     
  Lines         9253   114347   +105094     
============================================
+ Hits          7578    50985    +43407     
- Misses        1528    59707    +58179     
- Partials       147     3655     +3508     

Flag	Coverage Δ
cannon-go-tests-64	?
contracts-bedrock-tests	96.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
op-node/rollup/attributes/testutils.go	100.00% <100.00%> (ø)
op-node/rollup/driver/state.go	0.00% <ø> (ø)
op-node/rollup/engine/build_cancel.go	61.11% <100.00%> (ø)
op-node/rollup/engine/build_invalid.go	82.05% <100.00%> (ø)
op-node/rollup/engine/build_seal.go	64.17% <100.00%> (ø)
op-node/rollup/engine/build_sealed.go	100.00% <100.00%> (ø)
op-node/rollup/engine/build_start.go	83.05% <100.00%> (ø)
op-node/rollup/engine/build_started.go	100.00% <100.00%> (ø)
op-node/rollup/engine/events.go	59.13% <ø> (ø)
op-node/rollup/engine/payload_invalid.go	40.00% <0.00%> (ø)
... and 6 more

... and 1338 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.