op-node: revive async block processing timing log#17915
Merged
bitwiseguy merged 2 commits intodevelopfrom Oct 21, 2025
Merged
Conversation
axelKingsley
approved these changes
Oct 17, 2025
bitwiseguy
force-pushed
the
ss/op-node-log-block-processing-data
branch
3 times, most recently
from
93e15f0 to
182c6c0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
scharissis
approved these changes
Oct 20, 2025
Contributor
scharissis
left a comment
scharissis
left a comment
There was a problem hiding this comment.
LGTM; left a few questions/nits
bitwiseguy
force-pushed
the
ss/op-node-log-block-processing-data
branch
3 times, most recently
from
15cd643 to
ce11d7e
Compare
bitwiseguy
force-pushed
the
ss/op-node-log-block-processing-data
branch
from
ce11d7e to
384914b
Compare
theochap
pushed a commit
that referenced
this pull request
Oct 22, 2025
* op-node: revive async block processing timing log * op-node: add clarifying comments to logBlockProcessingMetrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
To provide more visibility into block processing performance (useful for benchmarking execution clients), it's useful to log the time it takes to execute all 4 engineApi calls
op-nodemakes to its execution client as part of the block processing lifecycle.Additional context
Last year we merged this pr, which updated both code paths to log the block processing durations. This pr from ~2 months ago removed the log from the async code path. It would also be good to add some metrics for some of the logged data field, but can do that in a follow-up pr.
Open questions