Conversation
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17101 +/- ##
===========================================
- Coverage 45.75% 44.51% -1.24%
===========================================
Files 1478 1423 -55
Lines 119949 115279 -4670
===========================================
- Hits 54877 51321 -3556
+ Misses 61226 60276 -950
+ Partials 3846 3682 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mds1
changed the title
pcw109550
reviewed
Aug 18, 2025
pcw109550
approved these changes
Aug 18, 2025
teddyknox
reviewed
Aug 18, 2025
teddyknox
reviewed
Aug 18, 2025
teddyknox
reviewed
Aug 18, 2025
teddyknox
approved these changes
Aug 18, 2025
Contributor
teddyknox
left a comment
teddyknox
left a comment
There was a problem hiding this comment.
Approved with non-blocking comments to apply to future refactors.
janjakubnanista
pushed a commit
that referenced
this pull request
Aug 19, 2025
… CrossSafeUpdateEvent (#17101) * refactor: remove CrossUpdateRequestEvent * refactor: remove CrossUnsafeUpdateEvent and CrossSafeUpdateEvent * build: compile time check that statusTracker implements the handlers * doc: add todo comments * refactor: remove no-op code * refactor: unify into a single CrossUpdateHandler * refactor: extract nil checks to helper method
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
… CrossSafeUpdateEvent (ethereum-optimism#17101) * refactor: remove CrossUpdateRequestEvent * refactor: remove CrossUnsafeUpdateEvent and CrossSafeUpdateEvent * build: compile time check that statusTracker implements the handlers * doc: add todo comments * refactor: remove no-op code * refactor: unify into a single CrossUpdateHandler * refactor: extract nil checks to helper method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.