cannon: Feature toggle eventfd2 support#15408
Closed
ajsutton wants to merge 15 commits intombax/issue-13447/go-1.23from
Closed
cannon: Feature toggle eventfd2 support#15408ajsutton wants to merge 15 commits intombax/issue-13447/go-1.23from
ajsutton wants to merge 15 commits intombax/issue-13447/go-1.23from
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mbax/issue-13447/go-1.23 #15408 +/- ##
============================================================
- Coverage 46.35% 42.93% -3.43%
============================================================
Files 1227 1114 -113
Lines 103043 97543 -5500
============================================================
- Hits 47768 41881 -5887
- Misses 51906 52309 +403
+ Partials 3369 3353 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mbaxter
force-pushed
the
mbax/issue-13447/go-1.23
branch
2 times, most recently
from
df40740 to
2c6d87c
Compare
Contributor
Author
|
We landed this feature toggle support separately to adding the new sys call support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets up feature toggling for eventfd2 support so that we can support both the current production STF and the new one supporting eventfd2. The solidity implementation hasn't been updated yet.
Also since all the examples are now built with go1.23 tests are failing for versions other than the new multithreaded. Either need to go back to compiling them for 1.22 or only run those tests on the new version.
Builds on #14692