Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14692 +/- ##
===========================================
- Coverage 46.71% 46.67% -0.05%
===========================================
Files 1284 1284
Lines 106297 106327 +30
===========================================
- Hits 49656 49625 -31
- Misses 53146 53206 +60
- Partials 3495 3496 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
24334c5 to
2580f17
Compare
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
8c157c4 to
273a0da
Compare
df40740 to
2c6d87c
Compare
Update test program go versions, bump Dockerfile.repro to 1.23.8
2c6d87c to
3288691
Compare
mbaxter
commented
Apr 24, 2025
Closed
This was referenced Apr 28, 2025
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* cannon: Update go version * Noop eventfd2 syscall * Run semver-lock * Add new VM version * Add testdata for new state version * Update cannon-embeds task * Update test program go versions Update test program go versions, bump Dockerfile.repro to 1.23.8 * Tweak step limits in tests * Update cannon-embeds to embed versions 6 and 7 * Fix syscallNum type * Update tests to run across all relevant vm versions * Update contracts to feature-toggle the eventFd2 syscall * Run semver-lock * Update noop syscalls in tests * Disable program tests for the 32-bit VM * Fix reflection error * Skip 32-bit program tests * Fix fuzz test param * Update todo * Rename examples testdata to go-1-23 * Update references to testdata/examples * Fix testdata Makefile, add go-1-22 testdata * Undo MIPS2 version bump * Create separate dockerfile for go1.23 prestates * Run e2e tests against new vm * Fix semver comment * Use tagged cannon binaries for legacy 32-bit VMs * Bump MIPS64 version * Rework test helpers to avoid calling t.Parallel multiple times * Cut more calls to InitParallel * Reorder preimage docker build steps * Fix reproducible-prestate output for mt64Next * Drop the single-threaded VM variant from fp e2e tests * op-e2e: Use mt64Next prestate * ci: Extend timeout for cannon tests * op-e2e: Only run super cannon tests on the mt64Next variant. * op-e2e: Set cannon test timeout to 90m. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support Go 1.23 by implementing a noop eventfd2 syscall. Add a new
StateVersionVersionMultiThreaded64_v4(7) that enables this new functionality.Other changes:
testdata/exampleprogram files:testdata:go-1-22go-1-23go-1-22directory only holds the hello program which is used in thecannon-stf-verifymake taskmake reproducible-prestateto build the "next" cannon version, exported toop-program/bin/prestate-mt64Next.bin.gzDockerfile.repro.nextthat mirrorsDockerfile.reprobut builds with go 1.23 and only builds the latest version of Cannonop-stack-ops/Dockerfileto build deprecated 32-bit vms from a taggedcannonreleasePotential TODOs:
Tests
AllocTypeMTCannonNextalloc type to target the next Cannon versionMetadata
Part of #13447