Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15409 +/- ##
===========================================
- Coverage 46.48% 43.69% -2.80%
===========================================
Files 1250 1137 -113
Lines 103813 98307 -5506
===========================================
- Hits 48262 42957 -5305
+ Misses 52159 51971 -188
+ Partials 3392 3379 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mbaxter
reviewed
Apr 15, 2025
Contributor
mbaxter
left a comment
mbaxter
left a comment
There was a problem hiding this comment.
Thanks - looks good!
Left a few nits + I think we should do more validation in NewFromState.
All JSON files are unsupported.
mbaxter
approved these changes
Apr 16, 2025
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* cannon: Introduce feature toggles. * cannon: Support multiple current versions. * cannon: Update tests * cannon: Update tests for SysEventFd2 support * Only fuzz latest version. * cannon: Improve testing. * cannon: Remove eventfd2 support that snuck in. * cannon: Skip test more explicitly * cannon: Pick random version when fuzzing. * cannon: Verify that version is supported in NewFromState. All JSON files are unsupported. * cannon: Use helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces support for feature toggling cannon STF based on the state version. Only implements the go side of this currently and there are no features using toggles currently (#15408 shows how this would be used).
This also fully embraces the idea of their being more than one supported version (which is already true but currently there's only one supported version per "type").
Tests
Updated most tests to run over all supported versions rather than just the latest.