Merged
Conversation
|
tynes
approved these changes
Sep 15, 2021
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
## Description This PR adds a test to ensure that nodes sync properly the safe heads and have a consistent view of the state. For each kona-node, this test: - Gathers the node's safe head gossip over 10sec - Checks that all the other nodes that have seen all these safe heads have a consistent view with the gossiped safe heads. For now, we only have positive tests so we're lacking some coverage (what happens with rogue nodes, network failures, reorgs, ...). These cases will come once we adapt the integration testing suite to use `in-memory` mode. ## Note Adds back the real "large network configuration" to CI now that we have fixed CPU usage of the kona nodes #1853 ## Related issues Close #1463
theochap
added a commit
that referenced
this pull request
Jan 14, 2026
## Description This PR adds a test to ensure that nodes sync properly the safe heads and have a consistent view of the state. For each kona-node, this test: - Gathers the node's safe head gossip over 10sec - Checks that all the other nodes that have seen all these safe heads have a consistent view with the gossiped safe heads. For now, we only have positive tests so we're lacking some coverage (what happens with rogue nodes, network failures, reorgs, ...). These cases will come once we adapt the integration testing suite to use `in-memory` mode. ## Note Adds back the real "large network configuration" to CI now that we have fixed CPU usage of the kona nodes #1853 ## Related issues Close #1463
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pulling in the fix from
developso CI stops making the tags again.