This repository was archived by the owner on Jan 16, 2026. It is now read-only.
test(node/sync-e2e): adding e2e safe head sync tests#1857
Merged
Conversation
theochap
added
the
A-node
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theochap
commented
May 24, 2025
clabby
approved these changes
May 25, 2025
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
Test looks good! Only curious about the large increase in participants on the network; Could be pretty heavy to run in CI.
Contributor
|
Also need to update the serialization tests for the |
…fixing l2 block deserialization tests
theochap
force-pushed
the
theo/sync-e2e-tests
branch
from
cf56dd9 to
a655d34
Compare
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Description This PR adds a test to ensure that nodes sync properly the safe heads and have a consistent view of the state. For each kona-node, this test: - Gathers the node's safe head gossip over 10sec - Checks that all the other nodes that have seen all these safe heads have a consistent view with the gossiped safe heads. For now, we only have positive tests so we're lacking some coverage (what happens with rogue nodes, network failures, reorgs, ...). These cases will come once we adapt the integration testing suite to use `in-memory` mode. ## Note Adds back the real "large network configuration" to CI now that we have fixed CPU usage of the kona nodes op-rs/kona#1853 ## Related issues Close op-rs/kona#1463
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Description This PR adds a test to ensure that nodes sync properly the safe heads and have a consistent view of the state. For each kona-node, this test: - Gathers the node's safe head gossip over 10sec - Checks that all the other nodes that have seen all these safe heads have a consistent view with the gossiped safe heads. For now, we only have positive tests so we're lacking some coverage (what happens with rogue nodes, network failures, reorgs, ...). These cases will come once we adapt the integration testing suite to use `in-memory` mode. ## Note Adds back the real "large network configuration" to CI now that we have fixed CPU usage of the kona nodes #1853 ## Related issues Close #1463
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test to ensure that nodes sync properly the safe heads and have a consistent view of the state.
For each kona-node, this test:
For now, we only have positive tests so we're lacking some coverage (what happens with rogue nodes, network failures, reorgs, ...). These cases will come once we adapt the integration testing suite to use
in-memorymode.Note
Adds back the real "large network configuration" to CI now that we have fixed CPU usage of the kona nodes #1853
Related issues
Close #1463