Skip to content

deploy: Update deploy script to require MIPS64 for production networks#14564

Closed
mbaxter wants to merge 2 commits intodevelopfrom
mbax/upgrade-14/update-deploy
Closed

deploy: Update deploy script to require MIPS64 for production networks#14564
mbaxter wants to merge 2 commits intodevelopfrom
mbax/upgrade-14/update-deploy

Conversation

@mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Feb 27, 2025

Description

To prepare for Upgrade 14, update DeployImplementations script to require MIPS64 for production networks.

Tests

Updated unit test.

Metadata

Part of #14459

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.37%. Comparing base (48b645a) to head (0e47007).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14564      +/-   ##
===========================================
- Coverage    46.41%   43.37%   -3.04%     
===========================================
  Files         1036      922     -114     
  Lines        88779    83493    -5286     
===========================================
- Hits         41206    36219    -4987     
+ Misses       44507    44207     -300     
- Partials      3066     3067       +1     
Flag Coverage Δ
cannon-go-tests-32 61.92% <ø> (ø)
cannon-go-tests-64 56.57% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 117 files with indirect coverage changes

@maurelian
Copy link
Contributor

This PR LGTM. The issue in the upgrade tests is just that this line:

dii.set(dii.mipsVersion.selector, Config.useMultithreadedCannon() ? 2 : 1);

is using 1, because USE_MT_CANNON defaults to false here:

enabled_ = vm.envOr("USE_MT_CANNON", false);

For now, I'd suggest fixing that just by switching the default to true.

@mbaxter
Copy link
Contributor Author

mbaxter commented Mar 4, 2025

Closing - this PR is superseded by #14612

@mbaxter mbaxter closed this Mar 4, 2025
@mbaxter mbaxter deleted the mbax/upgrade-14/update-deploy branch October 23, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants