deploy: Update deploy script to require MIPS64 for production networks#14564
Closed
deploy: Update deploy script to require MIPS64 for production networks#14564
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14564 +/- ##
===========================================
- Coverage 46.41% 43.37% -3.04%
===========================================
Files 1036 922 -114
Lines 88779 83493 -5286
===========================================
- Hits 41206 36219 -4987
+ Misses 44507 44207 -300
- Partials 3066 3067 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
This PR LGTM. The issue in the upgrade tests is just that this line: is using For now, I'd suggest fixing that just by switching the default to |
Contributor
Author
|
Closing - this PR is superseded by #14612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To prepare for Upgrade 14, update
DeployImplementationsscript to requireMIPS64for production networks.Tests
Updated unit test.
Metadata
Part of #14459