Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14570 +/- ##
===========================================
- Coverage 46.41% 41.95% -4.46%
===========================================
Files 1036 865 -171
Lines 88779 78815 -9964
===========================================
- Hits 41206 33068 -8138
+ Misses 44507 42848 -1659
+ Partials 3066 2899 -167
Flags with carried forward coverage won't be shown. Click here to find out more. |
| getGameConstructorParams(IFaultDisputeGame(address(_disputeGame))); | ||
|
|
||
| // Set the new vm value. | ||
| params.vm = IBigStepper(_implementations.mipsImpl); |
There was a problem hiding this comment.
To confirm my understanding, this MIPS contract is the shared singleton instance right?
That would mean that after this upgrade every chain would point to the same MIPS contract instance and thus the same PreimageOracle instance. Currently a bunch of chains have their own deployment of MIPS and PreimageOracle which makes monitoring more complex so would be wonderful if that got fixed as part of this upgrade. Existing games would keep pointing to whatever MIPS/PreimageOracle they were using previously so there's no compatibility concerns here, I'm just checking my understanding to ensure we really do get everything switched to using the singletons.
There was a problem hiding this comment.
Yes - this is my understanding. @maurelian or @mslipper - can you confirm?
|
Replaced by #14612. |
3 participants
Description
Builds on #14564
Add a new OPCM contract for upgrade 14. Cut out upgrade logic so that
upgrade()is just deploying new game implementations with the new MIPS64.sol vm contract.Tests
TODO
Metadata
Part of #14459