Skip to content

deploy: Update deploy script to require MIPS64 for production networks #14564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbaxter wants to merge 2 commits into from
Closed

deploy: Update deploy script to require MIPS64 for production networks #14564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caeec82
Update DeployImplementations to use MIPS64 for production networks
mbaxter Feb 27, 2025
0e47007
Update comment
mbaxter Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/contracts-bedrock/scripts/deploy/DeployImplementations.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,10 +746,10 @@ contract DeployImplementations is Script {
uint256 mipsVersion = _dii.mipsVersion();
IPreimageOracle preimageOracle = IPreimageOracle(address(_dio.preimageOracleSingleton()));

// We want to ensure that the OPCM for upgrade 13 is deployed with Mips32 on production networks.
if (mipsVersion != 1) {
// We want to ensure that the OPCM for upgrade 14 is deployed with Mips64 on production networks.
if (mipsVersion != 2) {
if (block.chainid == Chains.Mainnet || block.chainid == Chains.Sepolia) {
revert("DeployImplementations: Only Mips32 should be deployed on Mainnet or Sepolia");
revert("DeployImplementations: Only Mips64 should be deployed on Mainnet or Sepolia");
}
}

Expand Down
6 changes: 3 additions & 3 deletions packages/contracts-bedrock/test/opcm/DeployImplementations.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,14 +432,14 @@ contract DeployImplementations_Test is Test {

function test_run_deployMipsV1OnMainnetOrSepolia_reverts() public {
setDefaults();
dii.set(dii.mipsVersion.selector, 2);
dii.set(dii.mipsVersion.selector, 1);

vm.chainId(Chains.Mainnet);
vm.expectRevert("DeployImplementations: Only Mips32 should be deployed on Mainnet or Sepolia");
vm.expectRevert("DeployImplementations: Only Mips64 should be deployed on Mainnet or Sepolia");
deployImplementations.run(dii, dio);

vm.chainId(Chains.Sepolia);
vm.expectRevert("DeployImplementations: Only Mips32 should be deployed on Mainnet or Sepolia");
vm.expectRevert("DeployImplementations: Only Mips64 should be deployed on Mainnet or Sepolia");
deployImplementations.run(dii, dio);
}
}
Expand Down