Holocene: L1 SystemConfig.sol extensions for setting 1559 params#12439
Closed
roberto-bayardo wants to merge 2 commits intoethereum-optimism:developfrom
Closed
Holocene: L1 SystemConfig.sol extensions for setting 1559 params#12439roberto-bayardo wants to merge 2 commits intoethereum-optimism:developfrom
roberto-bayardo wants to merge 2 commits intoethereum-optimism:developfrom
Conversation
roberto-bayardo
requested review from
Inphi,
ajsutton,
clabby and
protolambda
Collaborator
Author
|
Building on #12418 Keeping in draft until that one is merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12439 +/- ##
===========================================
- Coverage 64.60% 64.42% -0.19%
===========================================
Files 52 52
Lines 4371 4371
===========================================
- Hits 2824 2816 -8
- Misses 1372 1381 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
5 times, most recently
from
5076e8f to
bb65614
Compare
tynes
reviewed
Oct 14, 2024
| emit ConfigUpdate(VERSION, UpdateType.GAS_LIMIT, data); | ||
| } | ||
|
|
||
| /// @notice Updates the EIP-1559 parameters of the chain. Can only be called by the owner. |
Contributor
There was a problem hiding this comment.
This looks good to me! One additional consideration is if we want to do something in initialize like:
if (eip1559Denominator == 0 && eip1559Elasticity == 0) {
_setEIP1559Params(canyonDefaults);
}This would sync the L1 state of the system config with the L2 values that are being used
Collaborator
Author
There was a problem hiding this comment.
No strong feelings either way, but slight preference to leaving it 0, mostly because less code?
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
7 times, most recently
from
54feb0d to
34dfc06
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
34dfc06 to
524087b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the L1 SystemConfig.sol contract with the EIP-1559 parameters + their setters.