Conversation
| cfg.p2pSequencerAddress(), | ||
| Constants.DEFAULT_RESOURCE_CONFIG(), | ||
| cfg.batchInboxAddress(), | ||
| ISystemConfig.Addresses({ |
|
Semgrep found 2 require() must include a reason string Ignore this finding from sol-style-require-reason. |
clabby
force-pushed
the
cl/sys-cfg-holocene
branch
from
5d0fbb3 to
291fe93
Compare
clabby
force-pushed
the
cl/sys-cfg-holocene
branch
from
b45b012 to
19eef9d
Compare
clabby
force-pushed
the
cl/sys-cfg-holocene
branch
from
19eef9d to
27796d9
Compare
|
Optional: use |
clabby
force-pushed
the
cl/sys-cfg-holocene
branch
from
5fc72c5 to
e6a7fea
Compare
| ISystemConfig.Addresses memory opChainAddrs | ||
| ) = defaultSystemConfigParams(_selector, _input, _output); | ||
|
|
||
| address batchInboxAddress = chainIdToBatchInboxAddress(_input.l2ChainId); |
There was a problem hiding this comment.
again, stack too deep...
clabby
force-pushed
the
cl/sys-cfg-holocene
branch
from
3aa9539 to
d479c70
Compare
| _blobbasefeeScalar: 0, | ||
| _batcherHash: bytes32(0), | ||
| _gasLimit: 1, | ||
| _eip1559Denominator: 1, |
There was a problem hiding this comment.
We agreed on not modifying the initializer with inputs to reduce the integration pains with OP Stack Chain Manager. We agreed on emitting default canyon values, if the storage slots are set to 0 (first time the contract is initalized) rather than having input arguments. This will sync the L1 state with the L2 view of the state. The dependency that is introduced is that chains will need to update to a newer release of op-node BEFORE we do the contract upgrade. We will add a getter/setter for the values, which can be atomically called during the same batch the new implementation is set in the proxy. cc @roberto-bayardo for context. Probably easier to just start on a fresh branch
|
Replacing with #12439 |
4 participants
Overview
Introduces the changes to the
SystemConfig, specified by theHolocene hardfork.