Holocene: extend op-node to support configurable eip-1559 params#12418
Closed
roberto-bayardo wants to merge 1 commit intoethereum-optimism:developfrom
Closed
Holocene: extend op-node to support configurable eip-1559 params#12418roberto-bayardo wants to merge 1 commit intoethereum-optimism:developfrom
roberto-bayardo wants to merge 1 commit intoethereum-optimism:developfrom
Conversation
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
a073340 to
084754f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12418 +/- ##
===========================================
- Coverage 64.60% 64.42% -0.19%
===========================================
Files 52 52
Lines 4371 4371
===========================================
- Hits 2824 2816 -8
- Misses 1372 1381 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
roberto-bayardo
force-pushed
the
holocene-1559
branch
18 times, most recently
from
4265887 to
66bdf22
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
5 times, most recently
from
eb313c6 to
cdad566
Compare
Collaborator
Author
This PR should be a good reference for whoever takes this task on. |
roberto-bayardo
force-pushed
the
holocene-1559
branch
5 times, most recently
from
b29caa7 to
ba8c1e1
Compare
roberto-bayardo
changed the title
Collaborator
Author
|
Do not merge yet: currently depending on my op-geth fork ( ethereum-optimism/op-geth#402 ) |
roberto-bayardo
force-pushed
the
holocene-1559
branch
5 times, most recently
from
59df249 to
93bfe97
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
3 times, most recently
from
a2f5f44 to
73fc619
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
73fc619 to
f50c216
Compare
Collaborator
Author
|
replacing with #12496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for providing EIP-1559 params to the execution engine as required by Holocene upgrade.
Tests
Unit test added to make sure eip1559 parameters are specified properly in the payload attributes post holocene.
e2e tests will be in a followup PR.
Additional context
Metadata