feat: deployImplementations and depImplementationsInterop#12226
Merged
feat: deployImplementations and depImplementationsInterop#12226
Conversation
This was referenced Oct 1, 2024
Contributor
Author
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maurelian and the rest of your teammates on |
mds1
approved these changes
Oct 1, 2024
maurelian
force-pushed
the
opcm/in-tests/simplify-setupOPChain
branch
from
3d4cf94 to
dbbf2ac
Compare
maurelian
force-pushed
the
opcm/in-tests/use-dso
branch
from
f9afe08 to
6692195
Compare
maurelian
force-pushed
the
opcm/in-tests/simplify-setupOPChain
branch
from
5dd3a1f to
1ef1e14
Compare
Demonstrate that build breaks when using high level syntax
maurelian
force-pushed
the
opcm/in-tests/use-dso
branch
from
6692195 to
aea79cf
Compare
maurelian
force-pushed
the
opcm/in-tests/simplify-setupOPChain
branch
from
1ef1e14 to
590995a
Compare
maurelian
force-pushed
the
opcm/in-tests/simplify-setupOPChain
branch
from
590995a to
c2cb7ec
Compare
maurelian
changed the title
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…ptimism#12226) * feat: Use DeploySuperchain script in Deploy.s.sol Demonstrate that build breaks when using high level syntax * fix: Cannot set null protocol versions error * feat: Also save impls * fix: semver lock * fix: bump ProtocolVersions semver * feat: Add superchainProxyAdmin * feat: Undo removeing ProtocolVersion type from interface * fix: semver-lock * feat: remove setupOpChainAdmin * fix: transfer ProxyAdmin ownership after all setup is complete * feat: separate deployImplementations * feat: split up deployImplementations and deployImplementationsInterop * fix: lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves implementation deployments into
deployImplementationsanddeployImplementationsInterop. This more closely corresponds to the OPCM'sDeployImplementationsscript.