feat(deploy): deploy implementations before proxies #12114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
maurelian
requested review from
a team,
mds1 and
skeletor-spaceman
and removed request for
mbaxter and
skeletor-spaceman
maurelian
force-pushed
the
opcm/in-tests-1
branch
from
2b96737 to
814fbd7
Compare
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
9c814b5 to
54fdb53
Compare
maurelian
force-pushed
the
opcm/in-tests-1
branch
from
814fbd7 to
3c31225
Compare
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
744233a to
cf61e6a
Compare
maurelian
force-pushed
the
opcm/in-tests-1
branch
2 times, most recently
from
0ef2abf to
861be2d
Compare
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
cf61e6a to
f5c3b57
Compare
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
f5c3b57 to
1a22337
Compare
mds1
reviewed
Sep 25, 2024
mds1
approved these changes
Sep 25, 2024
Contributor
Author
Merge activity
|
This change prepares for the OPCM integration by deploying the implementations before the proxies. `intializeImplementations()` was renamed to `initializeProxies()` which is more accurate. Also the ASR's implementation was unnecessarily initialized with a proxy address for a constructor argument.
It must be deployed per chain because it is not MCP ready.
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
1a22337 to
f70779f
Compare
This was referenced Sep 30, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…m#12114) * feat(deploy): deploy implementations before proxies This change prepares for the OPCM integration by deploying the implementations before the proxies. `intializeImplementations()` was renamed to `initializeProxies()` which is more accurate. Also the ASR's implementation was unnecessarily initialized with a proxy address for a constructor argument. * test(deploy): Move ASR impl deployment to deployProxies It must be deployed per chain because it is not MCP ready. * test(deploy): Rename deploy functions to correspond to OPCM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prepares for the OPCM integration by deploying the implementations before the proxies.
intializeImplementations()was renamed toinitializeProxies()which is more accurate.Also the ASR's implementation was unnecessarily initialized with a proxy address for a constructor
argument.