Skip to content

feat: Use DeploySuperchain script in Deploy.s.sol #12203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maurelian merged 8 commits into from
Oct 2, 2024
Merged

feat: Use DeploySuperchain script in Deploy.s.sol #12203

maurelian merged 8 commits into from
Oct 2, 2024

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Sep 30, 2024

No description provided.

This was referenced Sep 30, 2024
Merged
Merged
Merged
@maurelian Graphite App
Copy link
Contributor Author

maurelian commented Sep 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maurelian and the rest of your teammates on Graphite Graphite

@maurelian maurelian mentioned this pull request Sep 30, 2024
Merged
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Sep 30, 2024

Semgrep found 1 sol-style-require-reason finding:

  • packages/contracts-bedrock/scripts/deploy/Deploy.s.sol

require() must include a reason string

Ignore this finding from sol-style-require-reason.

@maurelian maurelian force-pushed the opcm/in-tests/use-dso branch 2 times, most recently from 656c7b2 to f8421b0 Compare September 30, 2024 16:28
@maurelian maurelian force-pushed the opcm/in-tests-4 branch 2 times, most recently from f84ce54 to 936be21 Compare September 30, 2024 16:55
@maurelian maurelian force-pushed the opcm/in-tests/use-dso branch 3 times, most recently from 644ea24 to 48d6e74 Compare September 30, 2024 17:30
@maurelian maurelian marked this pull request as ready for review September 30, 2024 17:30
@maurelian maurelian requested a review from a team as a code owner September 30, 2024 17:30
@maurelian maurelian requested review from blmalone and removed request for a team September 30, 2024 17:30
maurelian
maurelian commented Sep 30, 2024
View reviewed changes
maurelian
maurelian commented Sep 30, 2024
View reviewed changes
@maurelian maurelian force-pushed the opcm/in-tests/use-dso branch from 287ac99 to 6339df7 Compare September 30, 2024 18:37
mds1
mds1 reviewed Sep 30, 2024
View reviewed changes
Base automatically changed from opcm/in-tests-4 to develop September 30, 2024 21:30
@maurelian Graphite App
Copy link
Contributor Author

maurelian commented Sep 30, 2024

Merge activity

  • Sep 30, 5:31 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@maurelian maurelian force-pushed the opcm/in-tests/use-dso branch from 719cb35 to f9afe08 Compare October 1, 2024 17:01
This was referenced Oct 1, 2024
Merged
Merged
@maurelian maurelian force-pushed the opcm/in-tests/use-dso branch from f9afe08 to 6692195 Compare October 1, 2024 20:23
@maurelian maurelian mentioned this pull request Oct 1, 2024
Merged
@maurelian maurelian force-pushed the opcm/in-tests/use-dso branch from 6692195 to aea79cf Compare October 2, 2024 02:11
mds1
mds1 approved these changes Oct 2, 2024
View reviewed changes
@maurelian maurelian added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit e7dbd84 Oct 2, 2024
@maurelian maurelian deleted the opcm/in-tests/use-dso branch October 2, 2024 15:05
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@maurelian @samlaf
feat: Use DeploySuperchain script in Deploy.s.sol (ethereum-optimism#…
b62bb45 
…12203)

* feat: Use DeploySuperchain script in Deploy.s.sol

Demonstrate that build breaks when using high level syntax

* fix: Cannot set null protocol versions error

* feat: Also save impls

* fix: semver lock

* fix: bump ProtocolVersions semver

* feat: Add superchainProxyAdmin

* feat: Undo removeing ProtocolVersion type from interface

* fix: semver-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mds1 mds1 mds1 approved these changes

@blmalone blmalone Awaiting requested review from blmalone blmalone is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maurelian @mds1