params: implement ECIP-1078/1079 feature activation#128
Merged
Conversation
> - https://github.com/ethereumclassic/ECIPs/pull/263/files?short_path=d39459a#diff-d39459a451d1f1cf1bb1d6b1fddcb4f0 > - https://github.com/ethereumclassic/ECIPs/pull/261/files#diff-f331ca50d292642838a6be87214ac1e7 Implements 'Phoenix' aka 'Aztlan Fix' fork specification which is described as a 'simultaneous' fork adjacent to the fork specified in ECIP-1061 and ECIP-1072. The intention is to sidestep potential vulnerabilities related to gas costs. Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
force-pushed
the
feat/ecip-1078
branch
from
f8d4e61 to
3bbcf56
Compare
soc1c
reviewed
Jan 31, 2020
soc1c
left a comment
soc1c
left a comment
There was a problem hiding this comment.
We need to explicitly disable EIP 2200. On Mordor it already triggered and on Kotti it will soon. For mainnet, we will decide next week.
soc1c
reviewed
Jan 31, 2020
|
proposed block numbers for phoenix/ecip-1078
|
soc1c
suggested changes
Feb 3, 2020
soc1c
left a comment
soc1c
left a comment
There was a problem hiding this comment.
- needs to disable eip-2200 on mordor and kotti
- needs to update block numbers for phoenix/ecip-1078
Author
|
@soc1c Thanks for review. I need to merge some stuff first, but then will address these things soon! |
Signed-off-by: meows <b5c6@protonmail.com>
Implements method for data types implementing ChainConfigurator/ CatHerder interface. Currently Parity, multigethv0, and go-ethereum implementations are bare, and will error if attempted to use. These data types, afaik, do not currently support this configuration. Signed-off-by: meows <b5c6@protonmail.com>
- Disable EIP2200 on mordor and kotti - Updates block activation numbers respectively Signed-off-by: meows <b5c6@protonmail.com>
soc1c
reviewed
Feb 5, 2020
soc1c
reviewed
Feb 5, 2020
soc1c
approved these changes
Feb 5, 2020
soc1c
left a comment
soc1c
left a comment
There was a problem hiding this comment.
logic looks good to me. left two comments for cosmetic improvements.
- Add nil-valued eip1884 field - Add EIP2200 enable/+disable for Classic mainnet reflecting ECIP1061/1078 - Adds nicknames for 3 latest ETC forks Signed-off-by: meows <b5c6@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements 'Phoenix' aka 'Aztlan Fix' fork specification
which is described as a 'simultaneous' fork adjacent
to the fork specified in ECIP-1061 and ECIP-1072.
The intention is to sidestep potential vulnerabilities
related to gas costs.
Signed-off-by: meows b5c6@protonmail.com