Skip to content

Move ECIP-1078 ("fix") to Last Call. Move ECIP-1079 ("redo") to Withdrawn.#285

Merged
soc1c merged 5 commits into
ethereumclassic:masterfrom
ETCCooperative:withdraw_1079
Feb 5, 2020
Merged

Move ECIP-1078 ("fix") to Last Call. Move ECIP-1079 ("redo") to Withdrawn.#285
soc1c merged 5 commits into
ethereumclassic:masterfrom
ETCCooperative:withdraw_1079

Conversation

@bobsummerwill
Copy link
Copy Markdown
Member

@bobsummerwill bobsummerwill commented Jan 31, 2020

Move ECIP-1078 ("fix") to Last Call.
Move ECIP-1079 ("redo") to Withdrawn.
Aztlán has activated on the Mordor testnet, so can no longer be withdrawn.
Proceeding with "fix" appears to be our best option.

Move ECIP-1079 ("redo") to Withdrawn.
Aztlán has activated on the Mordor testnet, so can no longer be withdrawn.
Proceeding with "fix" appears to be our best option.
Comment thread _specs/ecip-1078.md
Comment thread _specs/ecip-1078.md Outdated
Comment thread _specs/ecip-1078.md Outdated
Copy link
Copy Markdown
Contributor

@soc1c soc1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposed block numbers for the testnets in 4 and 5 weeks. please add a review period end.

Set block times for Mordor and Kotti as suggested by soc1c.
Block for ETC mainnet activation is still TBD, but estimated as April/May/June.
This means that Azltan+Phoenix is DELAYED from the earlier estimated 25th March 2020 target.
The reason for the delay is a mixture of the unpredictability of block mining (estimate was made back in October) and the need for more time given the misspecification which let to the need for the Phoenix HF.
Updated estimates for Kotti and ETC mainnet activation for Aztlan.
…ck for Phoenix as for Aztlan, even though that is still in May/June.

We certainly would not want to activate any LATER if we can avoid it.
And as per soc1c, we should avoid activation of Phoenix earlier than Azltan (too many edge-cases).
So, for good or bad, I guess we are locked into block 10_500_839, even though it is much later than originally planned (March 25th).
Given the "fly in the ointment" of the mis-specification, perhaps that is a blessing in disguise.

This does NOT stop us starting work towards features and fixes which would likely land in the HF after Atzlan/Phoenix.
We can do those in parallel on other testnets (like Astor).
Copy link
Copy Markdown
Member

@realcodywburns realcodywburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm- these should be individual pr's in the future to facilitate rejecting or accepting changes to each on their own

@bobsummerwill
Copy link
Copy Markdown
Member Author

Thanks, @realcodywburns.
I generally have (see see of individual changes I did for the Rejected ones).

I lumped these together, because they are these ECIPs are inter-related "options". ECIP-1079 is being withdrawn because ECIP-1078 is moving to Last Call. It would not make sense to progress one and not the other. Also tied into ECIP-1061 timelines.

Comment thread _specs/ecip-1078.md Outdated
Copy link
Copy Markdown
Contributor

@soc1c soc1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bob please stop editing all EIPs in a single PR

it's not important on which day exactly aztlan activated on what testnet

Comment thread _specs/ecip-1061.md Outdated
Comment thread _specs/ecip-1061.md Outdated
Comment thread _specs/ecip-1061.md
Comment thread _specs/ecip-1078.md Outdated
Comment thread _specs/ecip-1078.md Outdated
Comment thread _specs/ecip-1078.md Outdated
@meowsbits
Copy link
Copy Markdown
Member

I would propose to remove the calendar dates entirely.

…ate estimation.

Meowbits suggested we remove the dates entirely, but I do not think that is a good idea.
Humans do not think in blocks.
However inaccurate these dates might be, humans like to make plans and that requires dates.
@TheEnthusiasticAs
Copy link
Copy Markdown
Member

dont forget to lable this issue (I am not able), so the Project-Section of https://github.com/ethereumclassic can be followed correctly ). Thx

@soc1c soc1c merged commit 2a53a0b into ethereumclassic:master Feb 5, 2020
@bobsummerwill
Copy link
Copy Markdown
Member Author

@TheEnthusiasticAs What labelling would it need?
Also, this is a PR, not an issue.

@bobsummerwill bobsummerwill deleted the withdraw_1079 branch February 6, 2020 01:01
@bobsummerwill
Copy link
Copy Markdown
Member Author

@TheEnthusiasticAs So you are talking about https://github.com/orgs/ethereumclassic/projects/3?

@realcodywburns How is this working? There are some issues and some PRs. Both PRs showing on that Aztlan dashboard are actually already closed, but the metadata getting them onto that view are obviously wrong. How does this tagging work?

@TheEnthusiasticAs
Copy link
Copy Markdown
Member

TheEnthusiasticAs commented Feb 9, 2020

yes @bobsummerwill, that one. thx. I would lable in both cases, PRs & issues, to be to follow the done works.

@soc1c soc1c added this to the Aztlán Hardfork milestone Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants