Skip to content

feat: implement ETC networks configs ECIP1078#145

Merged
soc1c merged 1 commit into
masterfrom
feat/ecip-1078
Feb 13, 2020
Merged

feat: implement ETC networks configs ECIP1078#145
soc1c merged 1 commit into
masterfrom
feat/ecip-1078

Conversation

@meowsbits
Copy link
Copy Markdown

@meowsbits meowsbits commented Feb 11, 2020

This reverts commit f9c254e, with the effect and intention of only essentially re-opening #128.


The story goes:

...so ECIP1078 was introduced to master and removed with same PR (and #128 unintentionally closed).

This PR undoes the disabled ECIP1078, effectively proposing to enable it. Maybe even for real this time.

@meowsbits meowsbits requested review from soc1c and tzdybal February 11, 2020 13:09
@meowsbits meowsbits changed the title Revert "params: revert ETC networks configs to pre-ECIP1078" feat: implement ETC networks configs ECIP1078 Feb 11, 2020
Copy link
Copy Markdown

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@soc1c soc1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a release would be appreciated

@soc1c soc1c merged commit 4d4cf33 into master Feb 13, 2020
@soc1c soc1c deleted the feat/ecip-1078 branch February 13, 2020 08:34
@meowsbits
Copy link
Copy Markdown
Author

meowsbits commented Feb 17, 2020

ECIP1078 is still in Last Call state.

I'm not sure this should have been merged, and would have probably preferred it to remain a reference implementation until the ECIP is marked as Accepted.

Beyond that, cutting a release which includes block activation specifications which have not been finalized is bad form; we should wait until Accepted (like we should have to merge the specification).

https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1078.md

@meowsbits
Copy link
Copy Markdown
Author

^ cc @tzdybal @soc1c @ChunFuYang

@soc1c
Copy link
Copy Markdown

soc1c commented Feb 18, 2020

@meowsbits Last call period end is after the activation on the testnets. Maybe we can agree to cut a release without mainnet block number but for the testnets? What do you think?

@meowsbits
Copy link
Copy Markdown
Author

meowsbits commented Feb 18, 2020

That sounds like an acceptable compromise to me.

Although I will say that having the Last Call period end after the activation on the testnets was probably not the ideal way of structuring this.

Lesson learned for future: Let's specify activations to happen after the specification drafts themselves will have been finalized.

@soc1c
Copy link
Copy Markdown

soc1c commented Feb 18, 2020

We did that on purpose because we have another 3 months till mainnet activation. But I see what you are saying here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants