feat: implement ETC networks configs ECIP1078#145
Conversation
This reverts commit f9c254e.
|
ECIP1078 is still in I'm not sure this should have been merged, and would have probably preferred it to remain a reference implementation until the ECIP is marked as Beyond that, cutting a release which includes block activation specifications which have not been finalized is bad form; we should wait until https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1078.md |
|
^ cc @tzdybal @soc1c @ChunFuYang |
|
@meowsbits Last call period end is after the activation on the testnets. Maybe we can agree to cut a release without mainnet block number but for the testnets? What do you think? |
|
That sounds like an acceptable compromise to me. Although I will say that having the Last Call period end after the activation on the testnets was probably not the ideal way of structuring this. Lesson learned for future: Let's specify activations to happen after the specification drafts themselves will have been finalized. |
|
We did that on purpose because we have another 3 months till mainnet activation. But I see what you are saying here. |
This reverts commit f9c254e, with the effect and intention of only essentially re-opening #128.
The story goes:
...so ECIP1078 was introduced to
masterand removed with same PR (and #128 unintentionally closed).This PR undoes the disabled ECIP1078, effectively proposing to enable it. Maybe even for real this time.