Skip to content

Cleanup the deprecated experimental flags #19959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahrtr merged 2 commits into from
May 20, 2025
Merged

Cleanup the deprecated experimental flags #19959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fdbfe
Cleanup the deprecated experimental flags for etcdserver
ahrtr May 16, 2025
5625446
Cleanup experimental flags for e2e and robustness test
ahrtr May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions server/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,6 @@ type ServerConfig struct {
// be refined to mlock in-use area of bbolt only.
MemoryMlock bool `json:"memory-mlock"`

// ExperimentalTxnModeWriteWithSharedBuffer enable write transaction to use
// a shared buffer in its readonly check operations.
// TODO: Delete in v3.7
// Deprecated: Use TxnModeWriteWithSharedBuffer Feature Gate instead. Will be decommissioned in v3.7.
ExperimentalTxnModeWriteWithSharedBuffer bool `json:"experimental-txn-mode-write-with-shared-buffer"`

// BootstrapDefragThresholdMegabytes is the minimum number of megabytes needed to be freed for etcd server to
// consider running defrag during bootstrap. Needs to be set to non-zero value to take effect.
BootstrapDefragThresholdMegabytes uint `json:"bootstrap-defrag-threshold-megabytes"`
Expand All @@ -204,8 +198,8 @@ type ServerConfig struct {
// V2Deprecation defines a phase of v2store deprecation process.
V2Deprecation V2DeprecationEnum `json:"v2-deprecation"`

// ExperimentalLocalAddress is the local IP address to use when communicating with a peer.
ExperimentalLocalAddress string `json:"experimental-local-address"`
// LocalAddress is the local IP address to use when communicating with a peer.
LocalAddress string `json:"local-address"`

// ServerFeatureGate is a server level feature gate
ServerFeatureGate featuregate.FeatureGate
Expand Down
275 changes: 9 additions & 266 deletions server/embed/config.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading