Skip to content

execution/stagedsync: remove canPrune from serial_exec#18800

Merged
AskAlexSharov merged 2 commits into
mainfrom
remove_serail_exec_can_prune
Jan 26, 2026
Merged

execution/stagedsync: remove canPrune from serial_exec#18800
AskAlexSharov merged 2 commits into
mainfrom
remove_serail_exec_can_prune

Conversation

@taratorio
Copy link
Copy Markdown
Member

@taratorio taratorio commented Jan 26, 2026

closes #17604 (in particular addresses the comment #17604 (comment))

this is no longer needed because now:

  • we always hold all exec updates in memory in SharedDomains
  • we break the sync loop (using ErrLoopExhausted) to allow for SharedDomains.Flush + tx.Commit + stageLoop.RunSync whenever:
    • --sync.loop.block.limit=5000 is reached
    • --batchSize=512MB is reached

@AskAlexSharov AskAlexSharov enabled auto-merge (squash) January 26, 2026 04:06
@AskAlexSharov AskAlexSharov merged commit c5c9e39 into main Jan 26, 2026
17 of 18 checks passed
@AskAlexSharov AskAlexSharov deleted the remove_serail_exec_can_prune branch January 26, 2026 05:10
mattevans added a commit to ethpandaops/erigone-legacy that referenced this pull request Jan 28, 2026
* main: (37 commits)
  Make `lastCommittedTxNum` atomic (erigontech#18820)
  integrity: fix redundant variable name in checkLogIdx (erigontech#18646)
  Fixed index building for v0 snapshot format (erigontech#18825)
  execution/vm: fold EVMInterpreter into EVM (erigontech#18765)
  fix: return correct prune mode value instead of nil (erigontech#18804)
  fix BuildMissedAccessors for caplin state (erigontech#18802)
  execution: EIP-7708: ETH transfers emit a log (erigontech#18761)
  refactor(rpc): remove redundant boolean comparison in AccountRange (erigontech#18814)
  Show the default P2P discovery bools in --help (erigontech#18818)
  fix(txpool): remove redundant Worst() calls in queued pool discard loop (erigontech#18810)
  node: remove unused logger and test helper (erigontech#18744)
  Disabled compression in collate function (erigontech#18813)
  Add missing tx.Commit() in stage_snapshots (erigontech#18816)
  Bumped major version of snapshot files (erigontech#18815)
  qa-tests: summary for RPC integration tests (erigontech#18809)
  perf: reuse hash buffer in witness storage leaf hash (erigontech#18803)
  execution/stagedsync: remove canPrune from serial_exec (erigontech#18800)
  Fixed deduplication intervals for rebuild cmd (erigontech#18796)
  Fix race due to warmup cache (erigontech#18799)
  fix(txpool): use instance logger instead of global log (erigontech#18797)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallel exec is missing canPrune break case

2 participants