fix(txpool): remove redundant Worst() calls in queued pool discard loop#18810
Merged
taratorio merged 1 commit intoJan 27, 2026
Merged
Conversation
AskAlexSharov
approved these changes
Jan 27, 2026
taratorio
approved these changes
Jan 27, 2026
mattevans
added a commit
to ethpandaops/erigone-legacy
that referenced
this pull request
Jan 28, 2026
* main: (37 commits) Make `lastCommittedTxNum` atomic (erigontech#18820) integrity: fix redundant variable name in checkLogIdx (erigontech#18646) Fixed index building for v0 snapshot format (erigontech#18825) execution/vm: fold EVMInterpreter into EVM (erigontech#18765) fix: return correct prune mode value instead of nil (erigontech#18804) fix BuildMissedAccessors for caplin state (erigontech#18802) execution: EIP-7708: ETH transfers emit a log (erigontech#18761) refactor(rpc): remove redundant boolean comparison in AccountRange (erigontech#18814) Show the default P2P discovery bools in --help (erigontech#18818) fix(txpool): remove redundant Worst() calls in queued pool discard loop (erigontech#18810) node: remove unused logger and test helper (erigontech#18744) Disabled compression in collate function (erigontech#18813) Add missing tx.Commit() in stage_snapshots (erigontech#18816) Bumped major version of snapshot files (erigontech#18815) qa-tests: summary for RPC integration tests (erigontech#18809) perf: reuse hash buffer in witness storage leaf hash (erigontech#18803) execution/stagedsync: remove canPrune from serial_exec (erigontech#18800) Fixed deduplication intervals for rebuild cmd (erigontech#18796) Fix race due to warmup cache (erigontech#18799) fix(txpool): use instance logger instead of global log (erigontech#18797) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop for discarding transactions from queued sub pool was calling Worst() twice per iteration with results discarded. This is dead code since Worst() has no side effects - it just returns the first element.
The two similar loops above (for pending and baseFee pools) don't have this issue, so this also makes the code consistent.