Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: in actions, each step should do one thing. #397

Closed
10 of 12 tasks
KristianKjerstad opened this issue Aug 3, 2023 · 1 comment
Closed
10 of 12 tasks

ci: in actions, each step should do one thing. #397

KristianKjerstad opened this issue Aug 3, 2023 · 1 comment
Assignees
@pbullhove
Labels
good first issue Good for newcomers

Comments

@KristianKjerstad
Copy link
Contributor

KristianKjerstad commented Aug 3, 2023 •
edited by pbullhove
Loading

ref discussion in #388 (review)

running reset script should be a separate step in the github action workflow

Go throught all github actions yaml files and make sure that each step is not too big.

  • codeql.yaml
  • create-release-pr.yaml
  • integration-tests.yaml
  • on-delete.yaml
  • on-main-push.yaml
  • on-push.yaml
  • on-schedule-nightly.yaml
  • on-tag.yaml
  • publish-integration-tests-report.yaml
  • remove-integration-tests-report.yaml
  • stale.yaml
  • tests.yaml
@KristianKjerstad KristianKjerstad mentioned this issue Aug 3, 2023
Merged
@ingeridhellen ingeridhellen mentioned this issue Aug 3, 2023
Merged
@KristianKjerstad KristianKjerstad added the good first issue Good for newcomers label Aug 4, 2023
@KristianKjerstad
Copy link
Contributor Author

optimally, one bash command per step

@pbullhove pbullhove assigned pbullhove and unassigned pbullhove Aug 7, 2023
@pbullhove pbullhove mentioned this issue Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbullhove pbullhove

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pbullhove @KristianKjerstad