-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #386: Add direct model allowing pass through to brms
#393
Conversation
Before I review can you follow up on where you have landed with "Remaining things to discuss IMO" points? |
|
Can you give a ping when this is ready for re-review as the tracker has got a bit confused |
Ready now. Should have things merged in, and added issues for all follow-up. |
Description
This PR closes #386.
It adds a pass through model called
direct_model
and the infrastructure needed to support it. It also adds tests for that model (both unit and integration).Remaining things to discuss IMO:
direct_model
I call the timesptime
andstime
-- this seems debateable: Update pass through model constructor to useepidist_linelist
#402direct_model
: Renamelatent_individual
anddirect_model
for consistency #400latent_individual
are better): Use naive model in getting started vignette to highlight impact of not adjusting #403Checklist