Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #386: Add direct model allowing pass through to brms #393

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Oct 16, 2024

Description

This PR closes #386.

It adds a pass through model called direct_model and the infrastructure needed to support it. It also adds tests for that model (both unit and integration).

Remaining things to discuss IMO:

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes marked this pull request as ready for review October 17, 2024 14:52
@athowes athowes requested a review from seabbs October 17, 2024 16:00
@seabbs
Copy link
Contributor

seabbs commented Oct 21, 2024

Before I review can you follow up on where you have landed with "Remaining things to discuss IMO" points?

@athowes
Copy link
Collaborator Author

athowes commented Oct 21, 2024

Before I review can you follow up on where you have landed with "Remaining things to discuss IMO" points?

  1. In the class constructor for direct_model I call the times ptime and stime -- this seems debateable: I think this is something we can figure out during the proprocessing work. As it sort of relates to e.g. taking epidist_linelist as input here

  2. Consider name different to direct_model: I'm fine with direct_model. One aspect that is dislikeable about it is that it ends in model. Whereas latent_individual doesn't. So maybe it should just be direct. There are lots of other possible options but I'm interested to hear your POV

  3. Follow up issue on using this in the getting started vignette to show why our models (e.g. latent_individual are better): yes this is something I can make

@seabbs
Copy link
Contributor

seabbs commented Oct 21, 2024

Can you give a ping when this is ready for re-review as the tracker has got a bit confused

@seabbs seabbs removed their request for review October 21, 2024 14:46
@athowes athowes requested a review from seabbs October 21, 2024 14:48
@athowes
Copy link
Collaborator Author

athowes commented Oct 21, 2024

Can you give a ping when this is ready for re-review as the tracker has got a bit confused

Ready now. Should have things merged in, and added issues for all follow-up.

@seabbs seabbs enabled auto-merge (squash) October 21, 2024 15:36
@seabbs seabbs merged commit a9b339a into main Oct 21, 2024
7 checks passed
@seabbs seabbs deleted the pass-through branch October 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pass through model
2 participants