-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for specific models #398
Labels
high
Required for next release
Comments
9 tasks
9 tasks
seabbs
pushed a commit
that referenced
this issue
Nov 19, 2024
seabbs
pushed a commit
that referenced
this issue
Jan 10, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
seabbs
pushed a commit
that referenced
this issue
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After we have the preprocessing interface solidified, we should go back and make sure that the models we have are documented well taking that preprocessing into account.
For example right now:
I was going to replace
data
here with an@inheritParam
from somehwere, but really thisdata
should be a different kind of parameter. One that is before the processing. Perhaps it should say "an object created usingas_linelist()
(or another constructor).Another example issue:
This shouldn't say
formula
as produced bybrms::brmsformula()
since it needs to have been run throughepidist_formula
. How to do this and share the argument nicely?We also need to do this for the direct / pass through model of PR #393.
The text was updated successfully, but these errors were encountered: