Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pass through model constructor to use epidist_linelist #402

Closed
athowes opened this issue Oct 21, 2024 · 1 comment
Closed

Update pass through model constructor to use epidist_linelist #402

athowes opened this issue Oct 21, 2024 · 1 comment
Assignees

Comments

@athowes
Copy link
Collaborator

athowes commented Oct 21, 2024

In the class constructor for direct_model I call the times ptime and stime -- this seems debateable

epidist_linelist will not be using ptime or stime. So we need to change things e.g. by using _lwr and constructing the delay that way. It's also possible that they delays could already be calculated within epidist_linelist.

@athowes
Copy link
Collaborator Author

athowes commented Nov 18, 2024

Uses stime_lwr now as of PR #441.

@athowes athowes closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant