Properly terminate DnsResolverFactory#876
Closed
jiajunye wants to merge 16 commits intoenvoyproxy:mainfrom
Closed
Conversation
Merge into my own fork
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Collaborator
|
Sorry for leading you in the wrong direction, I believe #877 contains the correct fix for the issue reported by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DnsResolverFactory::terminateFactoriesafter we initializing theDnsResolverFactoryin all places. We used to depend on the destructor ofDnsResolverFactoryto correctly destroy the object. This is no longer valid after Only call ares_library_init()/cleanup() routines in process_wide() if ares extension used in DNS resolving. envoy#21884.test_gccCI target. This test was disabled by Update Envoy to 0f0f675 (Jul 11th 2022) #869 to unblock the weekly Nighthawk update. See do_ci.sh test_gcc CI target fails #872 for more details about thetest_gccbreakage.Signed-off-by: jiajunye jiajunye@google.com