Properly terminate DnsResolverFactory

.azure-pipelines/pipelines.yml

@@ -61,6 +61,23 @@ stages:
       parameters:
         ciTarget: $(CI_TARGET)
 
+- stage: test_gcc
+  dependsOn: ["check"]
+  pool: "x64-large"
+  jobs:
+  - job: test_gcc
+    displayName: "do_ci.sh"
+    strategy:
+      maxParallel: 1
+      matrix:
+        test_gcc:
+          CI_TARGET: "test_gcc"
+    timeoutInMinutes: 120
+    steps:
+    - template: bazel.yml
+      parameters:
+        ciTarget: $(CI_TARGET)
+
 - stage: sanitizers
   dependsOn: ["test"]
   pool: "x64-large"
@@ -102,6 +119,7 @@ stages:
 - stage: release
   dependsOn:
   - "clang_tidy"
+  - "test_gcc"
   - "sanitizers"
   - "coverage"
   condition: eq(variables['PostSubmit'], true)

source/client/client.cc

@@ -79,6 +79,7 @@ bool Main::run() {
         *options_, dns_resolver_factory, std::move(typed_dns_resolver_config), time_system);
     if (!process_or_status.ok()) {
       ENVOY_LOG(error, "Unable to create ProcessImpl: {}", process_or_status.status().ToString());
+      Envoy::Network::DnsResolverFactory::terminateFactories();
       return false;
     }
     process = std::move(*process_or_status);

source/client/process_impl.cc

@@ -325,6 +325,7 @@ void ProcessImpl::shutdown() {
   }
   tls_.shutdownThread();
   dispatcher_->shutdown();
+  Envoy::Network::DnsResolverFactory::terminateFactories();
   shutdown_ = true;
 }
 

source/client/service_impl.cc

@@ -45,6 +45,7 @@ void ServiceImpl::handleExecutionRequest(const nighthawk::client::ExecutionReque
     response.mutable_error_detail()->set_message(
         fmt::format("Unable to create ProcessImpl: {}", process_or_status.status().ToString()));
     writeResponse(response);
+    Envoy::Network::DnsResolverFactory::terminateFactories();
     return;
   }
   ProcessPtr process = std::move(*process_or_status);