Fix python dependency version for NightHawk Benchmark image#633
Merged
mum4k merged 2 commits intoenvoyproxy:mainfrom Feb 23, 2021
Merged
Fix python dependency version for NightHawk Benchmark image#633mum4k merged 2 commits intoenvoyproxy:mainfrom
mum4k merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: abaptiste <abaptiste@users.noreply.github.com>
mum4k
approved these changes
Feb 23, 2021
Collaborator
mum4k
left a comment
There was a problem hiding this comment.
Thank you for the fix @abaptiste.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When invoking
ci/docker/benchmark_build.sh, the image build fails for me with:The change in this PR updates the Dockerfile to ensure that the python version listed is the minimum required version.
With this change in place, the docker image build script completes successfully:
cc: @oschaaf
Signed-off-by: abaptiste abaptiste@users.noreply.github.com