Remove strict equality for error message#632
Merged
mum4k merged 2 commits intoenvoyproxy:mainfrom Feb 23, 2021
Merged
Conversation
Signed-off-by: Teju Nareddy <nareddyt@google.com>
mum4k
approved these changes
Feb 22, 2021
Collaborator
mum4k
left a comment
mum4k
left a comment
There was a problem hiding this comment.
Thank you for the improvement.
Collaborator
mum4k
added
waiting-for-changes
Collaborator
|
Actually the merge wasn't necessary, the docker test is now passing. The remaining failure is likely a flake, retrying. |
mum4k
added
waiting-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend not to check for strict equality on error messages. This is aligned with Google Cloud APIs error model.
We are considering adding extra debug information to the underlying JSON parser library. The extra debug information breaks this test if it checks for strict equality.
Signed-off-by: Teju Nareddy nareddyt@google.com