Skip to content

bugfix: fix hpa/pdb deletion issue#6395

Merged
zirain merged 5 commits intoenvoyproxy:mainfrom
zirain:hpa-pdb
Jun 26, 2025
Merged

bugfix: fix hpa/pdb deletion issue#6395
zirain merged 5 commits intoenvoyproxy:mainfrom
zirain:hpa-pdb

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jun 24, 2025

follow up: #6337

fix issues when debuging #6393:

  • add e2e for custom HPA/PDB name.
  • fix labels on HPA/PDB which cause deletePDB/HPA not working.

@zirain zirain requested a review from a team as a code owner June 24, 2025 06:29
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (6f42531) to head (314ff5b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/infrastructure/kubernetes/infra_resource.go 63.15% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6395      +/-   ##
==========================================
+ Coverage   70.80%   70.81%   +0.01%     
==========================================
  Files         220      220              
  Lines       37132    37157      +25     
==========================================
+ Hits        26291    26314      +23     
+ Misses       9300     9297       -3     
- Partials     1541     1546       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain zirain requested a review from arkodg June 25, 2025 02:28
@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Jun 25, 2025

/retest

zirain added 5 commits June 25, 2025 17:18
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team June 25, 2025 16:42
@arkodg arkodg added the kind/bug Something isn't working label Jun 25, 2025
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jun 25, 2025
@zirain zirain merged commit 20f780e into envoyproxy:main Jun 26, 2025
62 of 66 checks passed
@zirain zirain deleted the hpa-pdb branch June 26, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants